[GitHub] [spark] srielau commented on a diff in pull request #39332: [WIP][SPARK-40822][SQL] Stable derived column aliases

[GitBox <gi...@apache.org>]

srielau commented on code in PR #39332:
URL: https://github.com/apache/spark/pull/39332#discussion_r1065013442


##########
sql/core/src/test/resources/sql-functions/sql-expression-schema.md:
##########
@@ -2,61 +2,61 @@
 ## Schema of Built-in Functions
 | Class name | Function name or alias | Query example | Output schema |

Review Comment:
   Yeah, I agree it seems a lot of the diffs are related to this, as well as the whitespace after , and around -/+, etc...
   I think our first goal is stability, our second reducing diffs to the existing algorithm.
   Note that Oracle does not put in ANY whitespace. They simply squish everything together.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org