You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/19 08:42:39 UTC
[GitHub] [flink] Tartarus0zm opened a new pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Tartarus0zm opened a new pull request #12931:
URL: https://github.com/apache/flink/pull/12931
## What is the purpose of the change
When flink job canceled/failed ,it need to wait all closeAsync finish.
but CompletedOperationCache’s closeAsync timeout is fixed at 300s,
so i think via configurable timeout is better.
## Brief change log
add `web.operation.cache.close.timeout` for CompletedOperationCache’s closeAsync timeout
## Verifying this change
no
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (yes / no / don't know)
## Documentation
- Does this pull request introduce a new feature? (no)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-660615418
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bfefeffa3e000035cecf499bd2dafa9acd500d9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4614",
"triggerID" : "9bfefeffa3e000035cecf499bd2dafa9acd500d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bfefeffa3e000035cecf499bd2dafa9acd500d9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4614)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-661763799
@flinkbot Azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann edited a comment on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
tillrohrmann edited a comment on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-664859003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-660615418
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bfefeffa3e000035cecf499bd2dafa9acd500d9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4614",
"triggerID" : "9bfefeffa3e000035cecf499bd2dafa9acd500d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bfefeffa3e000035cecf499bd2dafa9acd500d9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4614)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-660761914
@tillrohrmann please take a look,if you have time, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-664176684
Would it be possible to obtain the logs @Tartarus0zm? I would be interested what the exact problem is. Either there is an ongoing savepoint operation or the client does not request the final job result if it has been submitted in attached mode. For the latter case, a solution could be to submit a Flink job in detached mode.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-660610574
@GJL @wuchong please take a look,if you have time, thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm closed pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm closed pull request #12931:
URL: https://github.com/apache/flink/pull/12931
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-664859003
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-665054554
@tillrohrmann thanks for your explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-665596421
@tillrohrmann ok, closed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Tartarus0zm commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
Tartarus0zm commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-663808206
@tillrohrmann thank you for your reply!
In our company, sometimes user cancel flink per-job long time(about 5 min),the jobmaster has no log,but not exit.
after 5 min,we see a timeout message,so i find this code.
```
java.util.concurrent.TimeoutException
at org.apache.flink.runtime.concurrent.FutureUtils$Timeout.run(FutureUtils.java:999)
at org.apache.flink.runtime.concurrent.DirectExecutorService.execute(DirectExecutorService.java:211)
at org.apache.flink.runtime.concurrent.FutureUtils.lambda$orTimeout$14(FutureUtils.java:427)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
```
Because we prohibit users from resubmitting.
So let the user decide whether the timeout period is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] tillrohrmann commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-663396594
Thanks for creating this PR @Tartarus0zm. Why do you want to introduce this change? Differently asked, what problem are you encountering? Did you submit a job in attached per-job mode and then decide to cancel the job without waiting for the job result? Or did you create a savepoint and while doing this you decide that you no longer need it?
Assuming that this is the case, I think the proper solution would be to distinguish between a normal cluster shut down after the job has terminated where we want to wait that the results are being served and a user induced shut down (e.g. through cancellation) where one does not want to wait for results of asynchronous operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-660610603
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 9bfefeffa3e000035cecf499bd2dafa9acd500d9 (Sun Jul 19 08:44:58 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-18636).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12931: [FLINK-18636][rest] Asynchronous close via configurable timeout in seconds for CompletedOperationCache
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12931:
URL: https://github.com/apache/flink/pull/12931#issuecomment-660615418
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "9bfefeffa3e000035cecf499bd2dafa9acd500d9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9bfefeffa3e000035cecf499bd2dafa9acd500d9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 9bfefeffa3e000035cecf499bd2dafa9acd500d9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org