You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org> on 2021/09/28 00:40:31 UTC
[Impala-ASF-CR] Bump up the GBN to 17296101
Yu-Wen Lai has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17874
Change subject: Bump up the GBN to 17296101
......................................................................
Bump up the GBN to 17296101
This patch bumps up the GBN to 17296101. This build
includes HIVE-25137, which introduce a new HMS API
to get acid write events of a transaction.
Additionally, it excludes the ranger-plugins-audit
form the dependency of ranger-plugins-common so that
maven can resolve dependencies.
Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
3 files changed, 26 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/17874/1
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 2:
> Patch Set 1:
>
> (1 comment)
>
> LGTM. I left a minor comment below. I can +2 this once it is addressed.
Added. Could you please check again?
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 16:21:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9525/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Wed, 29 Sep 2021 16:40:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Yu-Wen Lai (Code Review)" <ge...@cloudera.org>.
Yu-Wen Lai has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Bump up the GBN to 17296101
This patch bumps up the GBN to 17296101. This build
includes HIVE-25137, which introduce a new HMS API
to get acid write events of a transaction.
Additionally, it excludes the ranger-plugins-audit
from the dependency of ranger-plugins-common so that
maven can resolve dependencies.
Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
3 files changed, 29 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/74/17874/2
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Bump up the GBN to 17296101
This patch bumps up the GBN to 17296101. This build
includes HIVE-25137, which introduce a new HMS API
to get acid write events of a transaction.
Additionally, it excludes the ranger-plugins-audit
from the dependency of ranger-plugins-common so that
maven can resolve dependencies.
Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Reviewed-on: http://gerrit.cloudera.org:8080/17874
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/impala-config.sh
M fe/pom.xml
M fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java
3 files changed, 29 insertions(+), 12 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 4
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7508/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 22:18:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Fri, 01 Oct 2021 04:35:38 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9510/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 01:03:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 3
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 22:18:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 1:
(1 comment)
LGTM. I left a minor comment below. I can +2 this once it is addressed.
http://gerrit.cloudera.org:8080/#/c/17874/1/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/17874/1/fe/pom.xml@122
PS1, Line 122: <exclusion>
: <groupId>org.apache.ranger</groupId>
: <artifactId>ranger-plugins-audit</artifactId>
: </exclusion>
can you please add a few lines comments here similar to other exclusions. Specifically, what was the problem when you included this.
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 22:04:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7496/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 00:42:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org>.
Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
LGTM.
http://gerrit.cloudera.org:8080/#/c/17874/1/fe/pom.xml
File fe/pom.xml:
http://gerrit.cloudera.org:8080/#/c/17874/1/fe/pom.xml@122
PS1, Line 122: <!-- We need to exclude ranger-plugins-audit here, or the build will fail
: to resolve dependencies for cruise-control-metrics-reporter, which is
: unneeded and not uploaded to toolchain. -->
: <exclusion>
> can you please add a few lines comments here similar to other exclusions. S
Done. Thanks for adding the comment.
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 2
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Comment-Date: Thu, 30 Sep 2021 22:18:29 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] Bump up the GBN to 17296101
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17874 )
Change subject: Bump up the GBN to 17296101
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17874
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I87a497882e80dbfc87077bdbc2f05216182003d6
Gerrit-Change-Number: 17874
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Wen Lai <yu...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 28 Sep 2021 07:00:03 +0000
Gerrit-HasComments: No