You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/10/29 10:14:26 UTC
[GitHub] [apisix] Firstsawyou opened a new issue #2563: [discuss]: support ctx.var to get service_name
Firstsawyou opened a new issue #2563:
URL: https://github.com/apache/apisix/issues/2563
DISCUSS：
In some scenarios, only by `service_id` it is not possible to directly tell which service is. I think that if we can support `ctx.var` to get `service_name`, then it will be easier for us to know which `service` is currently through `service_name`.
For example: when using the `prometheus` plugin, we only get the `service_id` through the Prometheus dashboard, which is not easy to understand the service. When the `service_name` field is added, we can more easily understand who this service is.
But `service_name` is not a unique identifier. I am not sure if adding `ctx.var` to get `service_name` is a good idea.
Welcome to discuss.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #2563: [discuss]: support ctx.var to get service_name
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on issue #2563:
URL: https://github.com/apache/apisix/issues/2563#issuecomment-718773592
> You can get the service name through service id, why must it be obtained through `ctx.var`?
Thank you very much, I got it. ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #2563: [discuss]: support ctx.var to get service_name
Posted by GitBox <gi...@apache.org>.
Firstsawyou commented on issue #2563:
URL: https://github.com/apache/apisix/issues/2563#issuecomment-718761138
> You can get the service name through service id, why must it be obtained through `ctx.var`?
Very good, thank you for your suggestion, I will try it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming commented on issue #2563: [discuss]: support ctx.var to get service_name
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #2563:
URL: https://github.com/apache/apisix/issues/2563#issuecomment-718650758
You can get the service name through service id, why must it be obtained through `ctx.var`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Firstsawyou closed issue #2563: [discuss]: support ctx.var to get service_name
Posted by GitBox <gi...@apache.org>.
Firstsawyou closed issue #2563:
URL: https://github.com/apache/apisix/issues/2563
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org