You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2026/08/28 03:54:31 UTC
[PR] fix(WorkflowExecutionService, v1.2): shutdown console writer thread on unsubscribe [texera]
github-actions[bot] opened a new pull request, #8063:
URL: https://github.com/apache/texera/pull/8063
### What changes were proposed in this PR?
Automated backport of #7914 to `release/v1.2`.
Source: bdc6d2a90eb1415014a4f705b7bb7cca31bb9688 · [automation run](https://github.com/apache/texera/actions/runs/33140232474)
### Any related issues, documentation, discussions?
Backport of #7914. Originally linked #7455.
### How was this PR tested?
Release-branch CI runs on this branch once the conflicts are resolved and this PR is marked ready for review.
### Was this PR authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(WorkflowExecutionService, v1.2): shutdown console writer thread on unsubscribe [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 commented on PR #8063:
URL: https://github.com/apache/texera/pull/8063#issuecomment-5724957456
Resolved by re-cherry-picking onto the current release/v1.2. Note: the regression test was dropped; it relies on the mock/fixture spec harness that only exists on main. The backport carries the fix only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(WorkflowExecutionService, v1.2): shutdown console writer thread on unsubscribe [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #8063:
URL: https://github.com/apache/texera/pull/8063#issuecomment-5725026901
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/8063?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `0%` with `8 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 53.08%. Comparing base ([`ba12d74`](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e759d79`](https://app.codecov.io/gh/apache/texera/commit/e759d7950b4e369b72a29157dd0a114460ad7b62?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:white_check_mark: All tests successful. No failed tests found.
| [Files with missing lines](https://app.codecov.io/gh/apache/texera/pull/8063?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...e/texera/web/service/ExecutionConsoleService.scala](https://app.codecov.io/gh/apache/texera/pull/8063?src=pr&el=tree&filepath=amber%2Fsrc%2Fmain%2Fscala%2Forg%2Fapache%2Ftexera%2Fweb%2Fservice%2FExecutionConsoleService.scala&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1iZXIvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS90ZXhlcmEvd2ViL3NlcnZpY2UvRXhlY3V0aW9uQ29uc29sZVNlcnZpY2Uuc2NhbGE=) | 0.00% | [8 Missing :warning: ](https://app.codecov.io/gh/apache/texera/pull/8063?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## release/v1.2 #8063 +/- ##
==================================================
- Coverage 53.09% 53.08% -0.02%
+ Complexity 2564 2561 -3
==================================================
Files 1078 1078
Lines 42360 42368 +8
Branches 4562 4563 +1
==================================================
- Hits 22491 22490 -1
- Misses 18550 18559 +9
Partials 1319 1319
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.35% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [amber](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.44% <0.00%> (-0.04%)` | :arrow_down: | |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `1.65% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.06% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `61.72% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `47.36% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `93.07% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.88% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/8063/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.69% <ø> (ø)` | | Carriedforward from [ba12d74](https://app.codecov.io/gh/apache/texera/commit/ba12d7439249e328bb1b1d758fcc110f046afa73?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/8063?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(WorkflowExecutionService, v1.2): shutdown console writer thread on unsubscribe [texera]
Posted by "xuang7 (via GitHub)" <gi...@apache.org>.
xuang7 merged PR #8063:
URL: https://github.com/apache/texera/pull/8063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(WorkflowExecutionService, v1.2): shutdown console writer thread on unsubscribe [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8063:
URL: https://github.com/apache/texera/pull/8063#issuecomment-5448192496
The cherry-pick **conflicted** and was committed with conflict markers. Resolve the conflicts on this branch, then mark this PR ready for review.
**Conflicting files:**
- `amber/src/test/scala/org/apache/texera/web/service/ExecutionConsoleServiceSpec.scala`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(WorkflowExecutionService, v1.2): shutdown console writer thread on unsubscribe [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #8063:
URL: https://github.com/apache/texera/pull/8063#issuecomment-5724946474
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- **Contributors with relevant context:** `@Yicong-Huang`
You can notify them by mentioning `@Yicong-Huang` in a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org