You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/10/09 15:14:52 UTC
[GitHub] [flink] bowenli86 commented on a change in pull request #9822:
[FLINK-14216][table] introduce temp system functions to FunctionCatalog
bowenli86 commented on a change in pull request #9822: [FLINK-14216][table] introduce temp system functions to FunctionCatalog
URL: https://github.com/apache/flink/pull/9822#discussion_r333073788
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/FunctionCatalog.java
##########
@@ -240,13 +298,24 @@ public PlannerTypeInferenceUtil getPlannerTypeInferenceUtil() {
return plannerTypeInferenceUtil;
}
- private void registerFunction(String name, FunctionDefinition functionDefinition) {
- // TODO: should register to catalog
- userFunctions.put(normalizeName(name), functionDefinition);
+ private void registerTempSystemFunction(String name, FunctionDefinition functionDefinition) {
+ tempSystemFunctions.put(normalizeName(name), functionDefinition);
+ }
+
+ private void registerTempCatalogFunction(ObjectIdentifier oi, FunctionDefinition functionDefinition) {
+ tempCatalogFunctions.put(normalizeObjectIdentifier(oi), functionDefinition);
}
@VisibleForTesting
static String normalizeName(String name) {
return name.toUpperCase();
}
+
+ @VisibleForTesting
+ static ObjectIdentifier normalizeObjectIdentifier(ObjectIdentifier oi) {
+ return ObjectIdentifier.of(
+ oi.getCatalogName(),
+ oi.getDatabaseName(),
Review comment:
currently catalog/db names are case sensitive in Flink. We haven't any normalization so far yet. I imagine we will be relying on the case sensitivity flag that should be introduced in Flink planner in the future
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services