You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Ralph Goers <Ra...@dslextreme.com> on 2004/12/27 16:51:16 UTC
Re: svn commit: r123405 - /cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java
Carsten,
Please revert this. It was specifically removed from trunk as it causes
a null pointer exception. The redirect is handled by Pluto in trunk.
See http://issues.apache.org/bugzilla/show_bug.cgi?id=32157 for an
explanation.
Ralph
cziegeler@apache.org wrote:
>Author: cziegeler
>Date: Mon Dec 27 05:37:40 2004
>New Revision: 123405
>
>URL: http://svn.apache.org/viewcvs?view=rev&rev=123405
>Log:
>Sync with 2.1.x - I guess someone forgot to add it to trunk as well?
>Modified:
> cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java
>
>Modified: cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java
>Url: http://svn.apache.org/viewcvs/cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java?view=diff&rev=123405&p1=cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java&r1=123404&p2=cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java&r2=123405
>==============================================================================
>--- cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java (original)
>+++ cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java Mon Dec 27 05:37:40 2004
>@@ -225,6 +225,10 @@
> final ServletRequestImpl req = (ServletRequestImpl) objectModel.get("portlet-request");
> final ServletResponseImpl res= (ServletResponseImpl)objectModel.get("portlet-response");
> this.portletContainer.processPortletAction(actionWindow, req.getRequest(actionWindow), res);
>+
>+ final String redirectURL = res.getRedirectURL();
>+ HttpServletResponse response = (HttpServletResponse) objectModel.get(HttpEnvironment.HTTP_RESPONSE_OBJECT);
>+ response.sendRedirect(redirectURL);
> } catch (Exception ignore) {
> this.getLogger().error("Error during processing of portlet action.", ignore);
> }
>
>
RE: svn commit: r123405 - /cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java
Posted by Carsten Ziegeler <cz...@apache.org>.
Hi Ralph,
sorry for the confusion and thanks for reverting! I will add a comment
to 2.1.x in order to make it obvious that trunk and 2.1.x have to
differ there. Thanks!
Carsten
> -----Original Message-----
> From: Ralph Goers [mailto:Ralph.Goers@dslextreme.com]
> Sent: Monday, December 27, 2004 7:13 PM
> To: dev@cocoon.apache.org
> Subject: Re: svn commit: r123405 -
> /cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/
> impl/PortletPortalManager.java
>
> Never mind. I reverted it myself. I'll be away for a few
> days. Talk to you when I get back.
>
> Ralph
>
> Ralph Goers wrote:
>
> > Carsten,
> > Please revert this. It was specifically removed from trunk as it
> > causes a null pointer exception. The redirect is handled
> by Pluto in
> > trunk. See http://issues.apache.org/bugzilla/show_bug.cgi?id=32157
> > for an explanation.
> >
> > Ralph
>
>
Re: svn commit: r123405 - /cocoon/trunk/src/blocks/portal/java/org/apache/cocoon/portal/impl/PortletPortalManager.java
Posted by Ralph Goers <Ra...@dslextreme.com>.
Never mind. I reverted it myself. I'll be away for a few days. Talk to
you when I get back.
Ralph
Ralph Goers wrote:
> Carsten,
> Please revert this. It was specifically removed from trunk as it
> causes a null pointer exception. The redirect is handled by Pluto in
> trunk. See http://issues.apache.org/bugzilla/show_bug.cgi?id=32157
> for an explanation.
>
> Ralph