You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ganeshmurthy <gi...@git.apache.org> on 2018/06/13 18:52:30 UTC

[GitHub] qpid-dispatch pull request #325: DISPATCH-1037 - Prevented deleting listener...

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/325

    DISPATCH-1037 - Prevented deleting listener with http: yes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-1037

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/325.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #325
    
----
commit 8276d91bfff40446f1a3e45a275ff0298331c569
Author: Ganesh Murthy <gm...@...>
Date:   2018-06-13T18:50:56Z

    DISPATCH-1037 - Prevented deleting listener with http: yes

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-dispatch issue #325: DISPATCH-1037 - Prevented deleting listener with h...

Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:

    https://github.com/apache/qpid-dispatch/pull/325
  
    # [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=h1) Report
    > Merging [#325](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/e6864f63e7086b1fee0063ff22803cae1fc14a35?src=pr&el=desc) will **increase** coverage by `0.02%`.
    > The diff coverage is `n/a`.
    
    [![Impacted file tree graph](https://codecov.io/gh/apache/qpid-dispatch/pull/325/graphs/tree.svg?src=pr&token=rk2Cgd27pP&width=650&height=150)](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=tree)
    
    ```diff
    @@            Coverage Diff             @@
    ##           master     #325      +/-   ##
    ==========================================
    + Coverage   86.54%   86.56%   +0.02%     
    ==========================================
      Files          69       69              
      Lines       15460    15462       +2     
    ==========================================
    + Hits        13380    13385       +5     
    + Misses       2080     2077       -3
    ```
    
    
    | [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=tree) | Coverage Δ | |
    |---|---|---|
    | [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.21% <0%> (-0.58%)` | :arrow_down: |
    | [src/remote\_sasl.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JlbW90ZV9zYXNsLmM=) | `82.72% <0%> (-0.31%)` | :arrow_down: |
    | [src/parse.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3BhcnNlLmM=) | `85.83% <0%> (-0.28%)` | :arrow_down: |
    | [src/iterator.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL2l0ZXJhdG9yLmM=) | `86.6% <0%> (-0.2%)` | :arrow_down: |
    | [src/message.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL21lc3NhZ2UuYw==) | `85.85% <0%> (-0.19%)` | :arrow_down: |
    | [src/router\_node.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9ub2RlLmM=) | `94.57% <0%> (+0.14%)` | :arrow_up: |
    | [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `71.54% <0%> (+0.14%)` | :arrow_up: |
    | [src/router\_core/connections.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2Nvbm5lY3Rpb25zLmM=) | `95.24% <0%> (+0.23%)` | :arrow_up: |
    | [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `99.25% <0%> (+0.37%)` | :arrow_up: |
    | [src/router\_core/transfer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/325/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3RyYW5zZmVyLmM=) | `90.73% <0%> (+0.62%)` | :arrow_up: |
    
    ------
    
    [Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=continue).
    > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
    > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
    > Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=footer). Last update [e6864f6...8276d91](https://codecov.io/gh/apache/qpid-dispatch/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).



---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org


[GitHub] qpid-dispatch pull request #325: DISPATCH-1037 - Prevented deleting listener...

Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy closed the pull request at:

    https://github.com/apache/qpid-dispatch/pull/325


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org