You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/26 13:54:27 UTC
[GitHub] [flink] sv3ndk opened a new pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
sv3ndk opened a new pull request #14764:
URL: https://github.com/apache/flink/pull/14764
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
* Provide additional examples of how to use the avro-confluent format. In particular, no example of how to serialize the kafka key or use the upsert connector are currently mentioned in the [avro confluent connector documentation](https://ci.apache.org/projects/flink/flink-docs-release-1.12/dev/table/connectors/formats/avro-confluent.html)
## Brief change log
- Added an example of a table serializing the kafka value in an avro record registered in the schema registry, while keeping the key in raw format
- Added an example of how to write to that table
- Added an example of a table using the schema registry for both the key and value
- Added an example of using the schema registry together with the kafka upsert connector
Only the English version of the documentation has been updated so far. Once the examples are approved, I'm happy to copy/paste them to the Chinese version of the documentation, at which point I'll need support for the few sentences that were updated/added.
## Verifying this change
Manually executed `./build_docs.sh -p` to check visually the result
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? no
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767576041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e5106da1732cba93446aa63fc61cdf7e74b29271 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767576041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12519",
"triggerID" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e5106da1732cba93446aa63fc61cdf7e74b29271 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12519)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong merged pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #14764:
URL: https://github.com/apache/flink/pull/14764
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767576041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12519",
"triggerID" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"triggerType" : "PUSH"
}, {
"hash" : "72b7c0d03d710be89bc6e7bdcff7c6a27980323c",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12579",
"triggerID" : "72b7c0d03d710be89bc6e7bdcff7c6a27980323c",
"triggerType" : "PUSH"
}, {
"hash" : "038ad0d6915e874ca32cce0da55184a436737a53",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12582",
"triggerID" : "038ad0d6915e874ca32cce0da55184a436737a53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 038ad0d6915e874ca32cce0da55184a436737a53 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12582)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14764:
URL: https://github.com/apache/flink/pull/14764#discussion_r565802781
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -45,29 +45,132 @@ Dependencies
connector=connector
%}
-How to create a table with Avro-Confluent format
-----------------
-
-Here is an example to create a table using Kafka connector and Confluent Avro format.
+Usage examples
+--------------
<div class="codetabs" markdown="1">
<div data-lang="SQL" markdown="1">
+
+Example of a table using raw UTF-8 string as Kafka key and Avro records registered in the Schema Registry as Kafka values:
+
{% highlight sql %}
-CREATE TABLE user_behavior (
- user_id BIGINT,
- item_id BIGINT,
- category_id BIGINT,
- behavior STRING,
- ts TIMESTAMP(3)
+CREATE TABLE user_created (
+
+ -- one column mapped to the Kafka raw UTF-8 key
+ the_kafka_key STRING,
+
+ -- a few columns mapped to the Avro fields of the Kafka value
+ id STRING,
+ name STRING,
+ email STRING
+
) WITH (
+
'connector' = 'kafka',
+ 'topic' = 'user_events_example1',
'properties.bootstrap.servers' = 'localhost:9092',
- 'topic' = 'user_behavior',
- 'format' = 'avro-confluent',
- 'avro-confluent.schema-registry.url' = 'http://localhost:8081',
- 'avro-confluent.schema-registry.subject' = 'user_behavior'
+
+ -- UTF-8 string as Kafka keys, using the 'the_kafka_key' table column
+ 'key.format' = 'raw',
+ 'key.fields' = 'the_kafka_key',
+
+ 'value.format' = 'avro-confluent',
+ 'value.avro-confluent.schema-registry.url' = 'http://localhost:8082',
+ 'value.fields-include' = 'EXCEPT_KEY'
)
{% endhighlight %}
+
+To which we can write as follows):
Review comment:
I don't fully understand this sentence. Do you mean "We can write data into the kafka table as follows" ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] wuchong commented on a change in pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
wuchong commented on a change in pull request #14764:
URL: https://github.com/apache/flink/pull/14764#discussion_r565813102
##########
File path: docs/dev/table/connectors/formats/avro-confluent.zh.md
##########
@@ -52,20 +52,126 @@ Avro Schema Registry 格式只能与[Apache Kafka SQL连接器]({% link dev/tabl
<div class="codetabs" markdown="1">
<div data-lang="SQL" markdown="1">
+
+||TODO: TRANSLATION:||
Review comment:
We dont' need the tag. It's fine just place English content in Chinese docs.
##########
File path: docs/dev/table/connectors/formats/avro-confluent.zh.md
##########
@@ -35,7 +35,7 @@ Avro Schema Registry (``avro-confluent``) 格式能让你读取被 ``io.confluen
当以这种格式写入（序列化）记录时，Avro schema 是从 table schema 中推断出来的，并会用来检索要与数据一起编码的 schema id。我们会在配置的 Confluent Schema Registry 中配置的 [subject](https://docs.confluent.io/current/schema-registry/index.html#schemas-subjects-and-topics) 下，检索 schema id。subject 通过 `avro-confluent.schema-registry.subject` 参数来制定。
-Avro Schema Registry 格式只能与[Apache Kafka SQL连接器]({% link dev/table/connectors/kafka.zh.md %})结合使用。
+Avro Schema Registry 格式只能与[Apache Kafka SQL连接器]({% link dev/table/connectors/kafka.zh.md %})结合使用。||TODO: TRANSLATION:|| or the [Upsert Kafka SQL Connector]({% link dev/table/connectors/upsert-kafka.zh.md %}).
Review comment:
We can just repalce the whole sentence use the new English sentence.
```
The Avro Schema Registry format can only be used in conjunction with the [Apache Kafka SQL connector]({% link dev/table/connectors/kafka.zh.md %}) or the [Upsert Kafka SQL Connector]({% link dev/table/connectors/upsert-kafka.zh.md %}).
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767576041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12519",
"triggerID" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"triggerType" : "PUSH"
}, {
"hash" : "72b7c0d03d710be89bc6e7bdcff7c6a27980323c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "72b7c0d03d710be89bc6e7bdcff7c6a27980323c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e5106da1732cba93446aa63fc61cdf7e74b29271 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12519)
* 72b7c0d03d710be89bc6e7bdcff7c6a27980323c UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on a change in pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on a change in pull request #14764:
URL: https://github.com/apache/flink/pull/14764#discussion_r565808097
##########
File path: docs/dev/table/connectors/formats/avro-confluent.md
##########
@@ -45,29 +45,132 @@ Dependencies
connector=connector
%}
-How to create a table with Avro-Confluent format
-----------------
-
-Here is an example to create a table using Kafka connector and Confluent Avro format.
+Usage examples
+--------------
<div class="codetabs" markdown="1">
<div data-lang="SQL" markdown="1">
+
+Example of a table using raw UTF-8 string as Kafka key and Avro records registered in the Schema Registry as Kafka values:
+
{% highlight sql %}
-CREATE TABLE user_behavior (
- user_id BIGINT,
- item_id BIGINT,
- category_id BIGINT,
- behavior STRING,
- ts TIMESTAMP(3)
+CREATE TABLE user_created (
+
+ -- one column mapped to the Kafka raw UTF-8 key
+ the_kafka_key STRING,
+
+ -- a few columns mapped to the Avro fields of the Kafka value
+ id STRING,
+ name STRING,
+ email STRING
+
) WITH (
+
'connector' = 'kafka',
+ 'topic' = 'user_events_example1',
'properties.bootstrap.servers' = 'localhost:9092',
- 'topic' = 'user_behavior',
- 'format' = 'avro-confluent',
- 'avro-confluent.schema-registry.url' = 'http://localhost:8081',
- 'avro-confluent.schema-registry.subject' = 'user_behavior'
+
+ -- UTF-8 string as Kafka keys, using the 'the_kafka_key' table column
+ 'key.format' = 'raw',
+ 'key.fields' = 'the_kafka_key',
+
+ 'value.format' = 'avro-confluent',
+ 'value.avro-confluent.schema-registry.url' = 'http://localhost:8082',
+ 'value.fields-include' = 'EXCEPT_KEY'
)
{% endhighlight %}
+
+To which we can write as follows):
Review comment:
Thanks for the suggestion. Yes, indeed, that's what I meant.
I'll add a commit to use your version, it's clearer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767576041
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12519",
"triggerID" : "e5106da1732cba93446aa63fc61cdf7e74b29271",
"triggerType" : "PUSH"
}, {
"hash" : "72b7c0d03d710be89bc6e7bdcff7c6a27980323c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12579",
"triggerID" : "72b7c0d03d710be89bc6e7bdcff7c6a27980323c",
"triggerType" : "PUSH"
}, {
"hash" : "038ad0d6915e874ca32cce0da55184a436737a53",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "038ad0d6915e874ca32cce0da55184a436737a53",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 72b7c0d03d710be89bc6e7bdcff7c6a27980323c Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=12579)
* 038ad0d6915e874ca32cce0da55184a436737a53 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767556747
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit e5106da1732cba93446aa63fc61cdf7e74b29271 (Tue Jan 26 13:56:10 UTC 2021)
**Warnings:**
* Documentation files were touched, but no `.zh.md` files: Update Chinese documentation or file Jira ticket.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-767556747
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 038ad0d6915e874ca32cce0da55184a436737a53 (Fri May 28 08:14:44 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] sv3ndk commented on pull request #14764: [Flink-20999][docs] - adds usage examples to the Kafka Avro Confluent connector format
Posted by GitBox <gi...@apache.org>.
sv3ndk commented on pull request #14764:
URL: https://github.com/apache/flink/pull/14764#issuecomment-768791368
Thanks for the feed-back @wuchong .
I copied the code examples to the Chinese version of the documentation, although they contain some English sentences at the moment, which I'm not capable of translating. Please let me know if I should open a ticket for that part or if we can handle it as part of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org