You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David McLaughlin <da...@dmclaughlin.com> on 2014/06/24 23:27:54 UTC
Review Request 22944: Use tasksWithoutConfig on job page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/
-----------------------------------------------------------
Review request for Aurora, Deprecated Use kevints and Mark Chu-Carroll.
Bugs: AURORA-551
https://issues.apache.org/jira/browse/AURORA-551
Repository: aurora
Description
-------
Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
Diff: https://reviews.apache.org/r/22944/diff/
Testing
-------
./gradlew build
File Attachments
----------------
Mocked data for groups.
https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
Thanks,
David McLaughlin
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by Bill Farner <wf...@apache.org>.
> On July 29, 2014, 6:52 p.m., David McLaughlin wrote:
> > This already has two ship its. Mark, do you mind removing yourself and adding Bill?
FYI - i don't believe Mark will have RB permissions to edit the review. You can feel free to do the swap and proceed with the commit.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review49010
-----------------------------------------------------------
On June 24, 2014, 9:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 9:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review49010
-----------------------------------------------------------
This already has two ship its. Mark, do you mind removing yourself and adding Bill?
- David McLaughlin
On June 24, 2014, 9:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 9:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review48295
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On June 24, 2014, 2:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 2:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review48292
-----------------------------------------------------------
Ping?
- David McLaughlin
On June 24, 2014, 9:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 9:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by Bill Farner <wf...@apache.org>.
> On Aug. 1, 2014, 5:47 p.m., David McLaughlin wrote:
> > Ping. Can someone ship this?
Stepped in, as Kevin is buried. This is now on master as of 98561ea.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review49360
-----------------------------------------------------------
On July 29, 2014, 7:20 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 7:20 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html b3480acacf9073123887a05047bf73a6f7cd34be
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review49360
-----------------------------------------------------------
Ping. Can someone ship this?
- David McLaughlin
On July 29, 2014, 7:20 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 7:20 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Bill Farner.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html b3480acacf9073123887a05047bf73a6f7cd34be
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/
-----------------------------------------------------------
(Updated July 29, 2014, 7:20 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Rebase.
Bugs: AURORA-551
https://issues.apache.org/jira/browse/AURORA-551
Repository: aurora
Description
-------
Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
Diffs (updated)
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html b3480acacf9073123887a05047bf73a6f7cd34be
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
Diff: https://reviews.apache.org/r/22944/diff/
Testing
-------
./gradlew build
File Attachments
----------------
Mocked data for groups.
https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
Thanks,
David McLaughlin
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/
-----------------------------------------------------------
(Updated July 29, 2014, 7:19 p.m.)
Review request for Aurora, Kevin Sweeney and Bill Farner.
Changes
-------
Swapped out Mark for Bill.
I still don't have commit access, so can either Bill or Kevin commit this? I'll rebase first.
Bugs: AURORA-551
https://issues.apache.org/jira/browse/AURORA-551
Repository: aurora
Description
-------
Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
Diff: https://reviews.apache.org/r/22944/diff/
Testing
-------
./gradlew build
File Attachments
----------------
Mocked data for groups.
https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
Thanks,
David McLaughlin
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/#review46583
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Farner
On June 24, 2014, 9:30 p.m., David McLaughlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22944/
> -----------------------------------------------------------
>
> (Updated June 24, 2014, 9:30 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
>
>
> Bugs: AURORA-551
> https://issues.apache.org/jira/browse/AURORA-551
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
>
>
> Diffs
> -----
>
> src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
> src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
>
> Diff: https://reviews.apache.org/r/22944/diff/
>
>
> Testing
> -------
>
> ./gradlew build
>
>
> File Attachments
> ----------------
>
> Mocked data for groups.
> https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
>
>
> Thanks,
>
> David McLaughlin
>
>
Re: Review Request 22944: Use tasksWithoutConfig on job page
Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22944/
-----------------------------------------------------------
(Updated June 24, 2014, 9:30 p.m.)
Review request for Aurora, Kevin Sweeney and Mark Chu-Carroll.
Changes
-------
Fixing people line.
Bugs: AURORA-551
https://issues.apache.org/jira/browse/AURORA-551
Repository: aurora
Description
-------
Use tasksWithoutConfig on job page to reduce page load time for jobs with large amount of active instances.
Diffs
-----
src/main/resources/org/apache/aurora/scheduler/http/ui/groupSummary.html 129235f33494f9a97117409374268cf441b976ca
src/main/resources/org/apache/aurora/scheduler/http/ui/js/controllers.js fc8b40b775ab9a47d5b397cdf153e2facbac0e5e
src/main/resources/org/apache/aurora/scheduler/http/ui/js/services.js 8aef24237e6b6e90a31d90adfc5673e5d431dac7
Diff: https://reviews.apache.org/r/22944/diff/
Testing
-------
./gradlew build
File Attachments
----------------
Mocked data for groups.
https://reviews.apache.org/media/uploaded/files/2014/06/24/ae1a2a7d-446e-44bf-9caa-3c53d4bcabaa__Screen_Shot_2014-06-24_at_2.03.16_PM.png
Thanks,
David McLaughlin