[jira] [Commented] (TEZ-1748) Refactoring - Conslidate the Transition in TaskAttemptImpl

["Hitesh Shah (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238254#comment-14238254 ] 

Hitesh Shah commented on TEZ-1748:
----------------------------------

Cancelling patch for now as there is no consensus. 

> Refactoring - Conslidate the Transition in TaskAttemptImpl
> ----------------------------------------------------------
>
>                 Key: TEZ-1748
>                 URL: https://issues.apache.org/jira/browse/TEZ-1748
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.1
>            Reporter: Jeff Zhang
>            Assignee: Jeff Zhang
>         Attachments: TEZ-1748.patch
>
>
> 2 points:
> * Some common work needs to be done when TaskAttempt is completed (succeeded/killed/failed), like send event to Task, send event to AMScheduler( it depends on current state ), unregister taskHeartbeatHandler (it depends on current state), we could put them in one places like TaskAttemptImpl.finished(TaskAttemptState)
> * There're many kinds of TerminationTransition, most of them are very similar, can consolidate them into one or two Transition



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)