You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "YannByron (via GitHub)" <gi...@apache.org> on 2023/12/13 11:00:12 UTC
[PR] [spark] refine description of scan [incubator-paimon]
YannByron opened a new pull request, #2505:
URL: https://github.com/apache/incubator-paimon/pull/2505
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: close #xxx
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] optimize description of scan [incubator-paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on PR #2505:
URL: https://github.com/apache/incubator-paimon/pull/2505#issuecomment-1857415756
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] optimize description of scan [incubator-paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #2505:
URL: https://github.com/apache/incubator-paimon/pull/2505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] refine description of scan [incubator-paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #2505:
URL: https://github.com/apache/incubator-paimon/pull/2505#discussion_r1425206185
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonBaseScan.scala:
##########
@@ -72,4 +95,23 @@ abstract class PaimonBaseScan(table: Table, readBuilder: ReadBuilder, desc: Stri
}
super.supportedCustomMetrics() ++ paimonMetrics
}
+
+ override def description(): String = {
+ val requiredFieldNameStr = readSchema().map(_.name).mkString(",")
+ val pushedFiltersStr = if (filters.nonEmpty) {
+ ", PushedFilters: " + filters.map(_._1).mkString(",")
+ } else {
+ ""
+ }
+ val runtimeFiltersStr = if (runtimeFilters.nonEmpty) {
+ ", RuntimeFilters: " + runtimeFilters.mkString(",")
+ } else {
+ ""
+ }
+ super.description() + "["
+ "Fields: " + requiredFieldNameStr + pushedFiltersStr +
+ runtimeFiltersStr +
Review Comment:
maybe will we don't need requiredFieldNameStr and runtimeFiltersStr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] refine description of scan [incubator-paimon]
Posted by "Zouxxyy (via GitHub)" <gi...@apache.org>.
Zouxxyy commented on code in PR #2505:
URL: https://github.com/apache/incubator-paimon/pull/2505#discussion_r1425206185
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonBaseScan.scala:
##########
@@ -72,4 +95,23 @@ abstract class PaimonBaseScan(table: Table, readBuilder: ReadBuilder, desc: Stri
}
super.supportedCustomMetrics() ++ paimonMetrics
}
+
+ override def description(): String = {
+ val requiredFieldNameStr = readSchema().map(_.name).mkString(",")
+ val pushedFiltersStr = if (filters.nonEmpty) {
+ ", PushedFilters: " + filters.map(_._1).mkString(",")
+ } else {
+ ""
+ }
+ val runtimeFiltersStr = if (runtimeFilters.nonEmpty) {
+ ", RuntimeFilters: " + runtimeFilters.mkString(",")
+ } else {
+ ""
+ }
+ super.description() + "["
+ "Fields: " + requiredFieldNameStr + pushedFiltersStr +
+ runtimeFiltersStr +
Review Comment:
maybe will we don't need requiredFieldNameStr and runtimeFiltersStr, see `BatchScanExec`'s `simpleString`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [spark] refine description of scan [incubator-paimon]
Posted by "YannByron (via GitHub)" <gi...@apache.org>.
YannByron commented on code in PR #2505:
URL: https://github.com/apache/incubator-paimon/pull/2505#discussion_r1426121516
##########
paimon-spark/paimon-spark-common/src/main/scala/org/apache/paimon/spark/PaimonBaseScan.scala:
##########
@@ -72,4 +95,23 @@ abstract class PaimonBaseScan(table: Table, readBuilder: ReadBuilder, desc: Stri
}
super.supportedCustomMetrics() ++ paimonMetrics
}
+
+ override def description(): String = {
+ val requiredFieldNameStr = readSchema().map(_.name).mkString(",")
+ val pushedFiltersStr = if (filters.nonEmpty) {
+ ", PushedFilters: " + filters.map(_._1).mkString(",")
+ } else {
+ ""
+ }
+ val runtimeFiltersStr = if (runtimeFilters.nonEmpty) {
+ ", RuntimeFilters: " + runtimeFilters.mkString(",")
+ } else {
+ ""
+ }
+ super.description() + "["
+ "Fields: " + requiredFieldNameStr + pushedFiltersStr +
+ runtimeFiltersStr +
Review Comment:
They are not always same in case querying nested column or unsupported runtime filter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org