Re: [PR] spinlock+sched_lock [nuttx]

["anchao (via GitHub)" <gi...@apache.org>]

anchao commented on code in PR #14578:
URL: https://github.com/apache/nuttx/pull/14578#discussion_r1825311316


##########
include/nuttx/spinlock.h:
##########
@@ -529,6 +529,7 @@ irqstate_t spin_lock_irqsave_wo_note(FAR volatile spinlock_t *lock)
 {
   irqstate_t ret;
   ret = up_irq_save();
+  sched_lock_wo_note();

Review Comment:
   If a non-preemptive version of spinlock_irqsave is implemented, We could disable global interrupts after spinlock is acquired, which will allow the system to respond interrupts during the test set loop and improve RT performance



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org