You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/19 14:02:46 UTC
[GitHub] [airflow] mik-laj opened a new pull request #6855: [AIRFLOW-6307]
Improve support for a special characters in DAG's name in stats view
mik-laj opened a new pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855
Special characters are not properly handled. It can cause problem.
---
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
- https://issues.apache.org/jira/browse/AIRFLOW-XXX
- In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
- In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain docstrings that explain what it does
- If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#discussion_r361294268
##########
File path: airflow/www/views.py
##########
@@ -307,7 +307,7 @@ def dag_stats(self, session=None):
# Filter by get parameters
selected_dag_ids = {
- unquote(dag_id) for dag_id in request.args.get('dag_ids', '').split(',') if dag_id
+ unquote(dag_id) for dag_id in request.args.getlist('dag_ids[]') if dag_id
Review comment:
+1 -> [] is just a strange convention and not a widely used one. I tried to find anyone using it and could not find it..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on issue #6855: [AIRFLOW-6307] Improve
support for a special characters in DAG's name in stats view
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-567909127
Is a comma actually allowed in a dag ID? (Do we want to allow it?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ashb commented on a change in pull request #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#discussion_r360354337
##########
File path: airflow/www/views.py
##########
@@ -307,7 +307,7 @@ def dag_stats(self, session=None):
# Filter by get parameters
selected_dag_ids = {
- unquote(dag_id) for dag_id in request.args.get('dag_ids', '').split(',') if dag_id
+ unquote(dag_id) for dag_id in request.args.getlist('dag_ids[]') if dag_id
Review comment:
```suggestion
unquote(dag_id) for dag_id in request.args.getlist('dag_ids') if dag_id
```
There's no requirement on `[]` got `getlist`, and both of those characters get url-escaped which just makes the URL a bit ugly is all (and longer) :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #6855: [AIRFLOW-6307]
Improve support for a special characters in DAG's name in stats view
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#discussion_r374328889
##########
File path: airflow/www/views.py
##########
@@ -307,7 +307,7 @@ def dag_stats(self, session=None):
# Filter by get parameters
selected_dag_ids = {
- unquote(dag_id) for dag_id in request.args.get('dag_ids', '').split(',') if dag_id
+ unquote(dag_id) for dag_id in request.args.getlist('dag_ids[]') if dag_id
Review comment:
I found the real specifications that describe this format.
https://github.com/OAI/OpenAPI-Specification/blob/master/versions/3.0.2.md#style-examples last row.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/136dead8afc6510962eb7af043fc77fc22a2d1d3?src=pr&el=desc) will **increase** coverage by `0.15%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.49% 84.65% +0.15%
==========================================
Files 680 681 +1
Lines 38392 39067 +675
==========================================
+ Hits 32441 33072 +631
- Misses 5951 5995 +44
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/hooks/presto\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9wcmVzdG9faG9vay5weQ==) | `75.92% <0%> (-1.63%)` | :arrow_down: |
| [...low/contrib/operators/datastore\_import\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfaW1wb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_datastore.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YXN0b3JlLnB5) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_dataflow.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfZGF0YWZsb3cucHk=) | `93.33% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/dataflow\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhZmxvd19vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [...low/contrib/operators/datastore\_export\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9kYXRhc3RvcmVfZXhwb3J0X29wZXJhdG9yLnB5) | `100% <0%> (ø)` | :arrow_up: |
| ... and [28 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [136dead...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568874861
# [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=h1) Report
> Merging [#6855](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/0c840d1d8baf56952ec64e5229d74bf9aaf30849?src=pr&el=desc) will **increase** coverage by `0.09%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6855 +/- ##
==========================================
+ Coverage 84.55% 84.65% +0.09%
==========================================
Files 680 681 +1
Lines 38451 39067 +616
==========================================
+ Hits 32513 33072 +559
- Misses 5938 5995 +57
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/www/views.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy93d3cvdmlld3MucHk=) | `76.08% <ø> (ø)` | :arrow_up: |
| [airflow/example\_dags/tutorial.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9leGFtcGxlX2RhZ3MvdHV0b3JpYWwucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_bigquery.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfYmlncXVlcnkucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/gcp/example\_dags/example\_compute.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9nY3AvZXhhbXBsZV9kYWdzL2V4YW1wbGVfY29tcHV0ZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/hooks/gcp\_compute\_hook.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL2djcF9jb21wdXRlX2hvb2sucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_compute\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfY29tcHV0ZV9vcGVyYXRvci5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/contrib/operators/gcp\_bigtable\_operator.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9nY3BfYmlndGFibGVfb3BlcmF0b3IucHk=) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/cli/commands/celery\_command.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9jbGkvY29tbWFuZHMvY2VsZXJ5X2NvbW1hbmQucHk=) | `52.5% <0%> (ø)` | |
| [airflow/providers/amazon/aws/hooks/s3.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYW1hem9uL2F3cy9ob29rcy9zMy5weQ==) | `95.76% <0%> (+0.02%)` | :arrow_up: |
| [airflow/utils/dag\_processing.py](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree#diff-YWlyZmxvdy91dGlscy9kYWdfcHJvY2Vzc2luZy5weQ==) | `87.53% <0%> (+0.11%)` | :arrow_up: |
| ... and [8 more](https://codecov.io/gh/apache/airflow/pull/6855/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=footer). Last update [0c840d1...9b647bb](https://codecov.io/gh/apache/airflow/pull/6855?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj commented on a change in pull request #6855:
[AIRFLOW-6307] Improve support for a special characters in DAG's name in
stats view
Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#discussion_r363006129
##########
File path: airflow/www/views.py
##########
@@ -307,7 +307,7 @@ def dag_stats(self, session=None):
# Filter by get parameters
selected_dag_ids = {
- unquote(dag_id) for dag_id in request.args.get('dag_ids', '').split(',') if dag_id
+ unquote(dag_id) for dag_id in request.args.getlist('dag_ids[]') if dag_id
Review comment:
PHP uses this syntax, but it's not very popular in the Python world. I will delete it.
https://stackoverflow.com/a/9547490/1849502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] mik-laj closed pull request #6855: [AIRFLOW-6307] Improve
support for a special characters in DAG's name in stats view
Posted by GitBox <gi...@apache.org>.
mik-laj closed pull request #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #6855: [AIRFLOW-6307] Improve
support for a special characters in DAG's name in stats view
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #6855: [AIRFLOW-6307] Improve support for a special characters in DAG's name in stats view
URL: https://github.com/apache/airflow/pull/6855#issuecomment-568257041
> Is a comma actually allowed in a dag ID? (Do we want to allow it?)
Wr definitely don't want to allow comma.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services