You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "snazy (via GitHub)" <gi...@apache.org> on 2025/06/20 16:26:34 UTC
[PR] Testing: admin-tool testing workaround [polaris]
snazy opened a new pull request, #1918:
URL: https://github.com/apache/polaris/pull/1918
Looks like parallel admin-tool tests can run into port-clashes, that should not occur on port 8081.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Testing: several related admin-tool testing fixes [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy commented on code in PR #1918:
URL: https://github.com/apache/polaris/pull/1918#discussion_r2162927182
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -49,9 +56,13 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java
-quarkus.datasource.devservices.image-name=postgres:17-alpine
## Logging Configuration
# Set root logging level to WARN to avoid mostly irrelevant Quarkus log messages.
# The Admin tool communicates with the user via STDOUT/STDERR
-quarkus.log.level=WARN
\ No newline at end of file
+quarkus.log.level=WARN
+# Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' built-time warning.
+quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
Review Comment:
removed application-test
##########
runtime/service/src/test/resources/logback-test.xml:
##########
@@ -29,4 +29,11 @@
<root level="${log.level.console:-INFO}">
<appender-ref ref="console"/>
</root>
+
+ <!--
+ Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' build-time warning.
+ See https://github.com/quarkusio/quarkus/blob/2fbc20f445fad43aaf4f3f984b9ac8319c7c7f0a/extensions/agroal/deployment/src/main/java/io/quarkus/agroal/deployment/AgroalProcessor.java#L111
+ THIS IS A TECHNICAL NECESSITY, because of the
+ -->
+ <logger name="io.quarkus.agroal.deployment" level="ERROR"/>
Review Comment:
So - that warning is odd. It may or may not appear. But I cannot figure out why ... it did not appear yesterday but now it does again... But I'm not going to spend days on a log message
##########
runtime/admin/src/test/java/org/apache/polaris/admintool/relational/jdbc/RelationalJdbcAdminProfile.java:
##########
@@ -18,7 +18,7 @@
*/
package org.apache.polaris.admintool.relational.jdbc;
-import static org.apache.polaris.admintool.PostgresTestResourceLifecycleManager.INIT_SCRIPT;
+import static org.apache.polaris.admintool.PostgresEclipselinkTestResourceLifecycleManager.INIT_SCRIPT;
Review Comment:
It's been there before :shrug:
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -49,9 +56,10 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java
-quarkus.datasource.devservices.image-name=postgres:17-alpine
## Logging Configuration
# Set root logging level to WARN to avoid mostly irrelevant Quarkus log messages.
# The Admin tool communicates with the user via STDOUT/STDERR
-quarkus.log.level=WARN
\ No newline at end of file
+quarkus.log.level=WARN
Review Comment:
Looks like the test-port settings aren't necessary - seems there was something else at play
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Testing: several related admin-tool testing fixes [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1918:
URL: https://github.com/apache/polaris/pull/1918#discussion_r2161994868
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -49,9 +56,13 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java
-quarkus.datasource.devservices.image-name=postgres:17-alpine
## Logging Configuration
# Set root logging level to WARN to avoid mostly irrelevant Quarkus log messages.
# The Admin tool communicates with the user via STDOUT/STDERR
-quarkus.log.level=WARN
\ No newline at end of file
+quarkus.log.level=WARN
+# Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' built-time warning.
+quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
+
+quarkus.http.test-port=0
+quarkus.management.test-port=0
Review Comment:
nit: maybe move them to the`-test` properties file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Testing: several related admin-tool testing fixes [polaris]
Posted by "snazy (via GitHub)" <gi...@apache.org>.
snazy merged PR #1918:
URL: https://github.com/apache/polaris/pull/1918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Testing: several related admin-tool testing fixes [polaris]
Posted by "dimas-b (via GitHub)" <gi...@apache.org>.
dimas-b commented on code in PR #1918:
URL: https://github.com/apache/polaris/pull/1918#discussion_r2161993256
##########
runtime/admin/src/main/resources/application-test.properties:
##########
@@ -0,0 +1,22 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+# Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' build-time warning.
+# See https://github.com/quarkusio/quarkus/blob/2fbc20f445fad43aaf4f3f984b9ac8319c7c7f0a/extensions/agroal/deployment/src/main/java/io/quarkus/agroal/deployment/AgroalProcessor.java#L111
+quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
Review Comment:
Is this necessary given a similar change in `application.properties`?
##########
runtime/admin/src/main/resources/application.properties:
##########
@@ -49,9 +56,13 @@ quarkus.index-dependency.guava.group-id=com.google.guava
quarkus.index-dependency.guava.artifact-id=guava
quarkus.index-dependency.protobuf.group-id=com.google.protobuf
quarkus.index-dependency.protobuf.artifact-id=protobuf-java
-quarkus.datasource.devservices.image-name=postgres:17-alpine
## Logging Configuration
# Set root logging level to WARN to avoid mostly irrelevant Quarkus log messages.
# The Admin tool communicates with the user via STDOUT/STDERR
-quarkus.log.level=WARN
\ No newline at end of file
+quarkus.log.level=WARN
+# Prevent the 'The Agroal dependency is present but no JDBC datasources have been defined.' built-time warning.
+quarkus.log.category."io.quarkus.agroal.deployment".level=ERROR
+
+quarkus.http.test-port=0
+quarkus.management.test-port=0
Review Comment:
nit: maybe move then to the`-test` properties file?
##########
runtime/admin/src/test/java/org/apache/polaris/admintool/relational/jdbc/RelationalJdbcAdminProfile.java:
##########
@@ -18,7 +18,7 @@
*/
package org.apache.polaris.admintool.relational.jdbc;
-import static org.apache.polaris.admintool.PostgresTestResourceLifecycleManager.INIT_SCRIPT;
+import static org.apache.polaris.admintool.PostgresEclipselinkTestResourceLifecycleManager.INIT_SCRIPT;
Review Comment:
Depending on the deprecated EclipseLink code from the JDBC impl is odd... Why not just copy this constant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org