You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/03/17 02:47:15 UTC

[GitHub] [iotdb] MarcosZyk opened a new pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to MManager

MarcosZyk opened a new pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265


   ## Description
    To stick with the terms of our new cluster design and decrease the difficulty  of merge schemaEngine code with persistent schema, we rename MManager to SchemaEngine and SGMManager to MManager.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #5265: [IOTDB-2675] [IOTDB-2757] Rename MManager to SchemaEngine and SGMManager to SchemaRegion; fix can not restart due to mtree-snapthot does not exist

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265#issuecomment-1070286859


   
   [![Coverage Status](https://coveralls.io/builds/47450798/badge)](https://coveralls.io/builds/47450798)
   
   Coverage decreased (-0.01%) to 65.433% when pulling **c01ce98b944e9c48bac355bcc6214233570ac86a on MarcosZyk:schema_engine_rename** into **3deadae57f71d434c3ea7974270dd45f17c7db07 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] qiaojialin merged pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to SchemaRegion

Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to SchemaRegion

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265#issuecomment-1070286859


   
   [![Coverage Status](https://coveralls.io/builds/47449328/badge)](https://coveralls.io/builds/47449328)
   
   Coverage increased (+0.007%) to 65.451% when pulling **c01ce98b944e9c48bac355bcc6214233570ac86a on MarcosZyk:schema_engine_rename** into **3deadae57f71d434c3ea7974270dd45f17c7db07 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] MarcosZyk commented on pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to MManager

Posted by GitBox <gi...@apache.org>.
MarcosZyk commented on pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265#issuecomment-1070365942


   > SGMManager -> SchemaRegion
   
   Fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls edited a comment on pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to SchemaRegion

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265#issuecomment-1070286859


   
   [![Coverage Status](https://coveralls.io/builds/47448202/badge)](https://coveralls.io/builds/47448202)
   
   Coverage decreased (-0.007%) to 65.437% when pulling **8aea31813ad1abed644e663971f843f0c200878a on MarcosZyk:schema_engine_rename** into **3deadae57f71d434c3ea7974270dd45f17c7db07 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] coveralls commented on pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to MManager

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265#issuecomment-1070286859


   
   [![Coverage Status](https://coveralls.io/builds/47444566/badge)](https://coveralls.io/builds/47444566)
   
   Coverage decreased (-0.005%) to 65.436% when pulling **cc987dcc5de286217f68d2e0d17950baf46e72ac on MarcosZyk:schema_engine_rename** into **3c22c124285daaba317341e89682cbd81607d622 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] qiaojialin commented on pull request #5265: [IOTDB-2675] Rename MManager to SchemaEngine and SGMManager to MManager

Posted by GitBox <gi...@apache.org>.
qiaojialin commented on pull request #5265:
URL: https://github.com/apache/iotdb/pull/5265#issuecomment-1070320574


   SGMManager -> SchemaRegion


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org