You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/04/01 17:40:27 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
michael-s-molina opened a new pull request #13919:
URL: https://github.com/apache/superset/pull/13919
### SUMMARY
Adds tests to the `UndoRedoKeyListeners` component.
### TEST PLAN
1 - Execute `UndoRedoKeyListeners` tests
2 - All tests should pass
@rusackas @junlincc
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13919:
URL: https://github.com/apache/superset/pull/13919#issuecomment-812196932
# [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=h1) Report
> Merging [#13919](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=desc) (c6fee2b) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **increase** coverage by `1.89%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head c6fee2b differs from pull request most recent head af412a1. Consider uploading reports for the commit af412a1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13919 +/- ##
==========================================
+ Coverage 76.38% 78.27% +1.89%
==========================================
Files 934 935 +1
Lines 47393 47480 +87
Branches 5964 5989 +25
==========================================
+ Hits 36199 37167 +968
+ Misses 11016 10169 -847
+ Partials 178 144 -34
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <100.00%> (+7.68%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `59.50% <100.00%> (+4.35%)` | :arrow_up: |
| [...ashboard/components/UndoRedoKeyListeners/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5TGlzdGVuZXJzL2luZGV4LmpzeA==) | `66.66% <100.00%> (ø)` | |
| [.../src/dashboard/components/UndoRedoKeylisteners.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5bGlzdGVuZXJzLmpzeA==) | `42.85% <0.00%> (-14.29%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `69.56% <0.00%> (-0.31%)` | :arrow_down: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.95% <0.00%> (+0.12%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `89.37% <0.00%> (+0.27%)` | :arrow_up: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `87.07% <0.00%> (+0.45%)` | :arrow_up: |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <0.00%> (+0.47%)` | :arrow_up: |
| [superset-frontend/src/components/ListView/utils.ts](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvdXRpbHMudHM=) | `85.95% <0.00%> (+0.82%)` | :arrow_up: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `61.25% <0.00%> (+1.25%)` | :arrow_up: |
| ... and [112 more](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=footer). Last update [1d8d067...af412a1](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13919:
URL: https://github.com/apache/superset/pull/13919#issuecomment-812196932
# [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=h1) Report
> Merging [#13919](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=desc) (c6fee2b) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.44%`.
> The diff coverage is `96.07%`.
> :exclamation: Current head c6fee2b differs from pull request most recent head 927c54f. Consider uploading reports for the commit 927c54f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13919 +/- ##
==========================================
+ Coverage 77.83% 78.27% +0.44%
==========================================
Files 934 935 +1
Lines 47320 47480 +160
Branches 5913 5989 +76
==========================================
+ Hits 36831 37167 +336
+ Misses 10346 10169 -177
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.04% <75.00%> (+0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `82.85% <ø> (ø)` | |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <ø> (ø)` | |
| [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `88.37% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `92.00% <50.00%> (-3.46%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <90.90%> (-0.36%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <94.87%> (+0.29%)` | :arrow_up: |
| ... and [33 more](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=footer). Last update [42c7e2c...927c54f](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13919:
URL: https://github.com/apache/superset/pull/13919#issuecomment-812196932
# [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=h1) Report
> Merging [#13919](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=desc) (3f656cf) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3f656cf differs from pull request most recent head 927c54f. Consider uploading reports for the commit 927c54f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13919 +/- ##
==========================================
+ Coverage 77.83% 77.90% +0.07%
==========================================
Files 934 939 +5
Lines 47320 47810 +490
Branches 5913 6085 +172
==========================================
+ Hits 36831 37248 +417
- Misses 10346 10418 +72
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `66.34% <100.00%> (+1.71%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.28% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `8.57% <ø> (ø)` | |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `94.30% <ø> (+0.55%)` | :arrow_up: |
| [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `87.50% <ø> (-0.88%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `60.00% <100.00%> (-6.92%)` | :arrow_down: |
| [...ashboard/components/UndoRedoKeyListeners/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5TGlzdGVuZXJzL2luZGV4LmpzeA==) | `100.00% <100.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `58.06% <100.00%> (+35.48%)` | :arrow_up: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `30.15% <100.00%> (+20.91%)` | :arrow_up: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `43.65% <100.00%> (+33.33%)` | :arrow_up: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=footer). Last update [42c7e2c...927c54f](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13919:
URL: https://github.com/apache/superset/pull/13919#issuecomment-812196932
# [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=h1) Report
> Merging [#13919](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=desc) (c6fee2b) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.32%`.
> The diff coverage is `96.07%`.
> :exclamation: Current head c6fee2b differs from pull request most recent head 927c54f. Consider uploading reports for the commit 927c54f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13919 +/- ##
==========================================
+ Coverage 77.83% 78.15% +0.32%
==========================================
Files 934 935 +1
Lines 47320 47480 +160
Branches 5913 5989 +76
==========================================
+ Hits 36831 37110 +279
+ Misses 10346 10222 -124
- Partials 143 148 +5
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `55.06% <75.00%> (-0.97%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/SqlLab/components/ScheduleQueryButton.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NjaGVkdWxlUXVlcnlCdXR0b24udHN4) | `28.12% <ø> (ø)` | |
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.76% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `65.71% <ø> (ø)` | |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <ø> (ø)` | |
| [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `88.37% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.74% <ø> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `92.00% <50.00%> (-3.46%)` | :arrow_down: |
| [superset/reports/commands/execute.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9leGVjdXRlLnB5) | `93.22% <90.90%> (-0.36%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.77% <94.87%> (+0.29%)` | :arrow_up: |
| ... and [42 more](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=footer). Last update [42c7e2c...927c54f](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13919:
URL: https://github.com/apache/superset/pull/13919#issuecomment-812196932
# [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=h1) Report
> Merging [#13919](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=desc) (624ad66) into [master](https://codecov.io/gh/apache/superset/commit/1d8d0675e63db5ebc2ba49ab58ca8b4bd785491c?el=desc) (1d8d067) will **decrease** coverage by `0.03%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 624ad66 differs from pull request most recent head af412a1. Consider uploading reports for the commit af412a1 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13919 +/- ##
==========================================
- Coverage 76.54% 76.50% -0.04%
==========================================
Files 934 935 +1
Lines 47393 47433 +40
Branches 5964 5974 +10
==========================================
+ Hits 36276 36289 +13
- Misses 10939 10965 +26
- Partials 178 179 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `66.34% <100.00%> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `52.00% <100.00%> (-3.15%)` | :arrow_down: |
| [...ashboard/components/UndoRedoKeyListeners/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5TGlzdGVuZXJzL2luZGV4LmpzeA==) | `100.00% <100.00%> (ø)` | |
| [...perset-frontend/src/explore/components/Control.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sLnRzeA==) | `91.66% <0.00%> (-0.34%)` | :arrow_down: |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `94.69% <0.00%> (+3.60%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=footer). Last update [1d8d067...af412a1](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina closed pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
michael-s-molina closed pull request #13919:
URL: https://github.com/apache/superset/pull/13919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13919:
URL: https://github.com/apache/superset/pull/13919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13919: test: Adds tests to the UndoRedoKeyListeners component
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13919:
URL: https://github.com/apache/superset/pull/13919#issuecomment-812196932
# [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=h1) Report
> Merging [#13919](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=desc) (3f656cf) into [master](https://codecov.io/gh/apache/superset/commit/9156f089ffb96fe765d67766cc015cf3d7df2faa?el=desc) (9156f08) will **increase** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 3f656cf differs from pull request most recent head 927c54f. Consider uploading reports for the commit 927c54f to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13919 +/- ##
==========================================
+ Coverage 77.83% 77.90% +0.07%
==========================================
Files 934 939 +5
Lines 47320 47810 +490
Branches 5913 6085 +172
==========================================
+ Hits 36831 37248 +417
- Misses 10346 10418 +72
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `66.34% <100.00%> (+1.71%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ontrols/AnnotationLayerControl/AnnotationLayer.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL0Fubm90YXRpb25MYXllci5qc3g=) | `84.28% <ø> (ø)` | |
| [...mponents/controls/AnnotationLayerControl/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sL2luZGV4LmpzeA==) | `8.57% <ø> (ø)` | |
| [...ponents/controls/DndColumnSelectControl/Option.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL09wdGlvbi50c3g=) | `100.00% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `94.30% <ø> (+0.55%)` | :arrow_up: |
| [.../explore/components/controls/TextControl/index.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9UZXh0Q29udHJvbC9pbmRleC50c3g=) | `87.50% <ø> (-0.88%)` | :arrow_down: |
| [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=) | `60.00% <100.00%> (-6.92%)` | :arrow_down: |
| [...ashboard/components/UndoRedoKeyListeners/index.jsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1VuZG9SZWRvS2V5TGlzdGVuZXJzL2luZGV4LmpzeA==) | `100.00% <100.00%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndColumnSelect.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZENvbHVtblNlbGVjdC50c3g=) | `58.06% <100.00%> (+35.48%)` | :arrow_up: |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `30.15% <100.00%> (+20.91%)` | :arrow_up: |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `43.65% <100.00%> (+33.33%)` | :arrow_up: |
| ... and [20 more](https://codecov.io/gh/apache/superset/pull/13919/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=footer). Last update [42c7e2c...927c54f](https://codecov.io/gh/apache/superset/pull/13919?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org