You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/02/19 17:31:35 UTC

[GitHub] [flink] tillrohrmann opened a new pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler 

tillrohrmann opened a new pull request #14970:
URL: https://github.com/apache/flink/pull/14970


   Renames the `DeclarativeScheduler` into `AdaptiveScheduler`.
   
   Note that this commit also changes the system property to enable the adaptive scheduler
   from `flink.tests.enable-declarative-scheduler` to `flink.tests.enable-adaptive-scheduler`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann closed pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #14970:
URL: https://github.com/apache/flink/pull/14970


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507",
       "triggerID" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c12ff62506a06a4316876810bd96cd2a144fcc26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507",
       "triggerID" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "triggerType" : "PUSH"
     }, {
       "hash" : "08cce5cbc57a8af1ac8699e615cf68d9b0fb8150",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13526",
       "triggerID" : "08cce5cbc57a8af1ac8699e615cf68d9b0fb8150",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 08cce5cbc57a8af1ac8699e615cf68d9b0fb8150 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13526) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782224653


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit c12ff62506a06a4316876810bd96cd2a144fcc26 (Fri Feb 19 17:34:46 UTC 2021)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507",
       "triggerID" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "triggerType" : "PUSH"
     }, {
       "hash" : "08cce5cbc57a8af1ac8699e615cf68d9b0fb8150",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "08cce5cbc57a8af1ac8699e615cf68d9b0fb8150",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c12ff62506a06a4316876810bd96cd2a144fcc26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507) 
   * 08cce5cbc57a8af1ac8699e615cf68d9b0fb8150 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-783181438


   Thanks for the review @zentol. Merging this PR now.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507",
       "triggerID" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c12ff62506a06a4316876810bd96cd2a144fcc26 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] tillrohrmann commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-784038261


   I forgot to rename them. I will update them in a hotfix commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-784045127


   Thanks a lot! 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507",
       "triggerID" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "triggerType" : "PUSH"
     }, {
       "hash" : "08cce5cbc57a8af1ac8699e615cf68d9b0fb8150",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13526",
       "triggerID" : "08cce5cbc57a8af1ac8699e615cf68d9b0fb8150",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c12ff62506a06a4316876810bd96cd2a144fcc26 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13507) 
   * 08cce5cbc57a8af1ac8699e615cf68d9b0fb8150 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=13526) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-782244636


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "c12ff62506a06a4316876810bd96cd2a144fcc26",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * c12ff62506a06a4316876810bd96cd2a144fcc26 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] rmetzger commented on pull request #14970: [FLINK-21390] Rename DeclarativeScheduler to AdaptiveScheduler

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14970:
URL: https://github.com/apache/flink/pull/14970#issuecomment-783609786


   Why were the configuration keys not renamed in this PR? 
   https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java#L391


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org