You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Attila Doroszlai <ad...@hortonworks.com> on 2016/12/21 16:52:53 UTC
Review Request 54942: AMBARI-19272. Ignored mount points logged for
each mount
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54942/
-----------------------------------------------------------
Review request for Ambari, Bal�zs Bence S�ri, Dmytro Grinenko, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.
Bugs: AMBARI-19272
https://issues.apache.org/jira/browse/AMBARI-19272
Repository: ambari
Description
-------
* Moved log out of the loop.
* Fixed typo ("was" -> "were")
Diffs
-----
ambari-agent/src/main/python/ambari_agent/Hardware.py 0d431a389ee492fc8557ae04b56a6c178d5a8fdd
Diff: https://reviews.apache.org/r/54942/diff/
Testing
-------
Verified that only the message with all ignored mounts is logged. (Note: /vagrant is really mounted twice.)
```
INFO 2016-12-21 16:41:03,424 Hardware.py:168 - Some mount points were ignored: /, /dev/shm, /boot, /vagrant, /vagrant
```
Ran unit tests:
```
$ mvn -am -pl ambari-agent clean test
...
Ran 451 tests in 15.070s
OK
...
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 151 licence.
...
[INFO] Ambari Agent ...................................... SUCCESS [17.537s]
```
Thanks,
Attila Doroszlai
Re: Review Request 54942: AMBARI-19272. Ignored mount points logged
for each mount
Posted by Dmytro Grinenko <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54942/#review160018
-----------------------------------------------------------
Ship it!
Ship It!
- Dmytro Grinenko
On Dec. 21, 2016, 4:52 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54942/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 4:52 p.m.)
>
>
> Review request for Ambari, Bal�zs Bence S�ri, Dmytro Grinenko, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-19272
> https://issues.apache.org/jira/browse/AMBARI-19272
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Moved log out of the loop.
> * Fixed typo ("was" -> "were")
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Hardware.py 0d431a389ee492fc8557ae04b56a6c178d5a8fdd
>
> Diff: https://reviews.apache.org/r/54942/diff/
>
>
> Testing
> -------
>
> Verified that only the message with all ignored mounts is logged. (Note: /vagrant is really mounted twice.)
>
> ```
> INFO 2016-12-21 16:41:03,424 Hardware.py:168 - Some mount points were ignored: /, /dev/shm, /boot, /vagrant, /vagrant
> ```
>
> Ran unit tests:
>
> ```
> $ mvn -am -pl ambari-agent clean test
> ...
> Ran 451 tests in 15.070s
>
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 151 licence.
> ...
> [INFO] Ambari Agent ...................................... SUCCESS [17.537s]
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>
Re: Review Request 54942: AMBARI-19272. Ignored mount points logged
for each mount
Posted by Sebastian Toader <st...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54942/#review159845
-----------------------------------------------------------
Ship it!
Ship It!
- Sebastian Toader
On Dec. 21, 2016, 5:52 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54942/
> -----------------------------------------------------------
>
> (Updated Dec. 21, 2016, 5:52 p.m.)
>
>
> Review request for Ambari, Bal�zs Bence S�ri, Dmytro Grinenko, Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.
>
>
> Bugs: AMBARI-19272
> https://issues.apache.org/jira/browse/AMBARI-19272
>
>
> Repository: ambari
>
>
> Description
> -------
>
> * Moved log out of the loop.
> * Fixed typo ("was" -> "were")
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/Hardware.py 0d431a389ee492fc8557ae04b56a6c178d5a8fdd
>
> Diff: https://reviews.apache.org/r/54942/diff/
>
>
> Testing
> -------
>
> Verified that only the message with all ignored mounts is logged. (Note: /vagrant is really mounted twice.)
>
> ```
> INFO 2016-12-21 16:41:03,424 Hardware.py:168 - Some mount points were ignored: /, /dev/shm, /boot, /vagrant, /vagrant
> ```
>
> Ran unit tests:
>
> ```
> $ mvn -am -pl ambari-agent clean test
> ...
> Ran 451 tests in 15.070s
>
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 151 licence.
> ...
> [INFO] Ambari Agent ...................................... SUCCESS [17.537s]
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>