[GitHub] [kyuubi] pan3793 commented on issue #4951: [Bug] Operation logs are unavailable with reload4j slf4j binding

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on issue #4951:
URL: https://github.com/apache/kyuubi/issues/4951#issuecomment-1590506765

   @touchida Thanks for reporting this issue, seems we can simply treat reload4j as log4j12, right?
   
   ```patch
   object Logging {
     ...
     private[kyuubi] def isLog4j12: Boolean = {
       // This distinguishes the log4j 1.2 binding, currently
       // org.slf4j.impl.Log4jLoggerFactory, from the log4j 2.0 binding, currently
       // org.apache.logging.slf4j.Log4jLoggerFactory
       "org.slf4j.impl.Log4jLoggerFactory"
   -     .equals(LoggerFactory.getILoggerFactory.getClass.getName)
   +     .equals(LoggerFactory.getILoggerFactory.getClass.getName) ||
   +   "org.slf4j.impl.Reload4jLoggerFactory"
   +     .equals(LoggerFactory.getILoggerFactory.getClass.getName)
     }
     ...
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org