[GitHub] [spark] tgravescs commented on a change in pull request #28053: [SPARK-29153][CORE]Add ability to merge resource profiles within a stage with Stage Level Scheduling

[GitBox <gi...@apache.org>]

tgravescs commented on a change in pull request #28053: [SPARK-29153][CORE]Add ability to merge resource profiles within a stage with Stage Level Scheduling
URL: https://github.com/apache/spark/pull/28053#discussion_r399524803
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/resource/ResourceProfileManager.scala
 ##########
 @@ -34,7 +34,7 @@ import org.apache.spark.util.Utils.isTesting
  */
 @Evolving
 private[spark] class ResourceProfileManager(sparkConf: SparkConf) extends Logging {
-  private val resourceProfileIdToResourceProfile = new ConcurrentHashMap[Int, ResourceProfile]()
+  private val resourceProfileIdToResourceProfile = new HashMap[Int, ResourceProfile]()
 
 Review comment:
   yep changed the synchronization due to concurrentHashMap not being friendly for the new function to find existing profiles.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org