[GitHub] [carbondata] ajantha-bhat commented on a change in pull request #3317: [CARBONDATA-3461] Carbon SDK support filter values set.

[GitBox <gi...@apache.org>]

ajantha-bhat commented on a change in pull request #3317: [CARBONDATA-3461] Carbon SDK support filter values set.
URL: https://github.com/apache/carbondata/pull/3317#discussion_r299852035
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
 ##########
 @@ -170,6 +176,75 @@ public CarbonReaderBuilder filter(Expression filterExpression) {
     return this;
   }
 
+  public CarbonReaderBuilder filter(String columnName, String value) {
 
 Review comment:
   this always creates equal to filter, so keeping filter as name is not good.
   
   I suggest change it to **`public static Expression prepareEqualToExpression(String columnName, String value)`**
   
   so get the equalto filter expression from above and then pass it to existing filter() method. This way it can support for all the filter expression.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services