You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "saurabhd336 (via GitHub)" <gi...@apache.org> on 2023/08/19 13:14:27 UTC
[GitHub] [pinot] saurabhd336 opened a new pull request, #11387: Fix casting issue when casting compatible types
saurabhd336 opened a new pull request, #11387:
URL: https://github.com/apache/pinot/pull/11387
```
SELECT CAST(TIMESTAMPADD(DAY, 1, "Calcs"."date2") AS TIMESTAMP) AS "TEMP_Test__670684053__0_"
FROM "Calcs"
GROUP BY "TEMP_Test__670684053__0_"
```
seems to fail with
```
"errorCode": 200,
"message": "QueryExecutionError:\njava.lang.RuntimeException: Error executing query: [0]@127.0.0.1:64177 MAIL_RECEIVE(RANDOM_DISTRIBUTED)\n└── [1]@127.0.0.1:64185 MAIL_SEND(RANDOM_DISTRIBUTED)->{[0]@127.0.0.1@{64177,64177}|[0]}\n └── [1]@127.0.0.1:64185 AGGREGATE_FINAL\n └── [1]@127.0.0.1:64185 MAIL_RECEIVE(HASH_DISTRIBUTED)\n └── [2]@127.0.0.1:64185 MAIL_SEND(HASH_DISTRIBUTED)->{[1]@127.0.0.1@{64185,64186}|[0]}\n...\nCaused by: java.lang.RuntimeException: Received error query execution result block: {1000=Incompatible selection result data schema: Expected: [TEMP_Test__670684053__0_(TIMESTAMP)]. Actual: [plus(date2,times('86400000','1'))(DOUBLE)]\njava.lang.IllegalStateException: Incompatible selection result data schema: Expected: [TEMP_Test__670684053__0_(TIMESTAMP)]. Actual: [plus(date2,times('86400000','1'))(DOUBLE)]\n\tat com.google.common.base.Preconditions.checkState(Preconditions.java:512)\n\tat org.apache.pinot.query.runtime.o
perator.LeafStageTransferableBlockOperator.composeDistinctTransferableBlock(LeafStageTransferableBlockOperator.java:181)\n\tat org.apache.pinot.query.runtime.operator.LeafStageTransferableBlockOperator.composeTransferableBlock(LeafStageTransferableBlockOperator.java:160)"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 closed pull request #11387: Fix casting issue when casting compatible types
Posted by "saurabhd336 (via GitHub)" <gi...@apache.org>.
saurabhd336 closed pull request #11387: Fix casting issue when casting compatible types
URL: https://github.com/apache/pinot/pull/11387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] saurabhd336 closed pull request #11387: Fix casting issue when casting compatible types
Posted by "saurabhd336 (via GitHub)" <gi...@apache.org>.
saurabhd336 closed pull request #11387: Fix casting issue when casting compatible types
URL: https://github.com/apache/pinot/pull/11387
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #11387: Fix casting issue when casting compatible types
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #11387:
URL: https://github.com/apache/pinot/pull/11387#issuecomment-1684948431
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11387?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11387](https://app.codecov.io/gh/apache/pinot/pull/11387?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (6d6c1b8) into [master](https://app.codecov.io/gh/apache/pinot/commit/a5a1641e60a6b484e1c8c2c5e55daf63a8412fa6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a5a1641) will **decrease** coverage by `46.87%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 6d6c1b8 differs from pull request most recent head 88003f2. Consider uploading reports for the commit 88003f2 to get more accurate results
```diff
@@ Coverage Diff @@
## master #11387 +/- ##
=============================================
- Coverage 61.42% 14.55% -46.87%
+ Complexity 6512 494 -6018
=============================================
Files 2234 2159 -75
Lines 120158 116958 -3200
Branches 18239 17786 -453
=============================================
- Hits 73811 17028 -56783
- Misses 40918 98519 +57601
+ Partials 5429 1411 -4018
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [integration2](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-11](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java-17](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.55% <0.00%> (-46.73%)` | :arrow_down: |
| [java-20](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.55% <0.00%> (-46.87%)` | :arrow_down: |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests2](https://app.codecov.io/gh/apache/pinot/pull/11387/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `14.55% <0.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...java/org/apache/pinot/common/utils/DataSchema.java](https://app.codecov.io/gh/apache/pinot/pull/11387?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvRGF0YVNjaGVtYS5qYXZh) | `0.00% <0.00%> (-68.58%)` | :arrow_down: |
... and [1470 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11387/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] shenyu0127 commented on pull request #11387: Fix casting issue when casting compatible types
Posted by "shenyu0127 (via GitHub)" <gi...@apache.org>.
shenyu0127 commented on PR #11387:
URL: https://github.com/apache/pinot/pull/11387#issuecomment-1685116009
- The tests are failing.
- We probably don't need this PR because we can modify the test framework to run the following query.
SELECT ToDateTime(TIMESTAMPADD(DAY, 1, "Calcs"."date2"), 'yyyy-MM-dd hh:mm:ss') AS "TEMP_Test__670684053__0_"
FROM "Calcs"
GROUP BY "TEMP_Test__670684053__0_"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org