You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2018/01/31 21:43:40 UTC
[native-toolchain-CR](cdh5.x) Build old versions of gperftools and thrift.
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9169
Change subject: Build old versions of gperftools and thrift.
......................................................................
Build old versions of gperftools and thrift.
We recently bumped gperftools and thrift version in the toolchain but
ran into issues when trying to use the new versions in Impala. This
change enabled builds of old versions of both dependencies, so that
we can bump versions of other dependencies.
Based on Lars Volker's patch.
Change-Id: Iee6c2a13dd288d0f7a8852c7100ec84c9c2e0ba3
---
M buildall.sh
M source/thrift/build.sh
2 files changed, 7 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/69/9169/1
--
To view, visit http://gerrit.cloudera.org:8080/9169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iee6c2a13dd288d0f7a8852c7100ec84c9c2e0ba3
Gerrit-Change-Number: 9169
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[native-toolchain-CR](cdh5.x) Build old versions of gperftools and thrift.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9169 )
Change subject: Build old versions of gperftools and thrift.
......................................................................
Patch Set 1: Code-Review+2
clean cherry-pick
--
To view, visit http://gerrit.cloudera.org:8080/9169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6c2a13dd288d0f7a8852c7100ec84c9c2e0ba3
Gerrit-Change-Number: 9169
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jan 2018 21:44:04 +0000
Gerrit-HasComments: No
[native-toolchain-CR](cdh5.x) Build old versions of gperftools and thrift.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9169 )
Change subject: Build old versions of gperftools and thrift.
......................................................................
Build old versions of gperftools and thrift.
We recently bumped gperftools and thrift version in the toolchain but
ran into issues when trying to use the new versions in Impala. This
change enabled builds of old versions of both dependencies, so that
we can bump versions of other dependencies.
Based on Lars Volker's patch.
Change-Id: Iee6c2a13dd288d0f7a8852c7100ec84c9c2e0ba3
---
M buildall.sh
M source/thrift/build.sh
2 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Thomas Tauber-Marshall: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/9169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee6c2a13dd288d0f7a8852c7100ec84c9c2e0ba3
Gerrit-Change-Number: 9169
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
[native-toolchain-CR](cdh5.x) Build old versions of gperftools and thrift.
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/9169 )
Change subject: Build old versions of gperftools and thrift.
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9169
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: native-toolchain
Gerrit-Branch: cdh5.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee6c2a13dd288d0f7a8852c7100ec84c9c2e0ba3
Gerrit-Change-Number: 9169
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
Gerrit-Comment-Date: Wed, 31 Jan 2018 21:44:06 +0000
Gerrit-HasComments: No