[GitHub] [hive] abstractdog commented on a change in pull request #2477: HIVE-25329: CTAS creates a managed table as non-ACID table

[GitBox <gi...@apache.org>]

abstractdog commented on a change in pull request #2477:
URL: https://github.com/apache/hive/pull/2477#discussion_r693802859



##########
File path: ql/src/test/queries/clientpositive/create_table.q
##########
@@ -0,0 +1,39 @@
+set hive.support.concurrency=true;
+set hive.txn.manager=org.apache.hadoop.hive.ql.lockmgr.DbTxnManager;
+set hive.create.as.external.legacy=true;
+
+-- When hive.create.as.external.legacy is true, the tables created with
+-- 'managed' or 'transactional' are ACID tables but the tables create
+-- without 'managed' and 'transactional' are non-ACID tables.
+-- Note: managed non-ACID tables are allowed because tables are not
+-- transformed when hive.in.test is true.
+
+-- Create tables with 'transactional'. These tables have table property
+-- 'transactional'='true'
+create transactional table test11 as select 1;
+show create table test11;
+describe formatted test11;
+
+create transactional table test12 as select 1;

Review comment:
       why are all the test cases duplicated here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org