You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Mark Reibert <sv...@reibert.com> on 2007/08/29 23:24:53 UTC

[PATCH] svn_load_dirs.pl: export for final consistency check

Hi,

svn_load_dirs.pl performs a final consistency check by checking out the
tag and diff'ing against the import directory. It seems this would be
handled better (hopefully faster) by using "svn export" and bypassing
the "-x .svn" on diff.

[[[
* contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in
  Export instead of checkout for final consistency check.
]]]

-- 
----------------------
Mark S. Reibert, Ph.D.
svn@reibert.com
----------------------

Re: [PATCH] svn_load_dirs.pl: export for final consistency check

Posted by Mark Reibert <sv...@reibert.com>.
On Thu, 2007-08-30 at 14:27 -0700, Daniel Rall wrote:
> > svn_load_dirs.pl performs a final consistency check by checking out  
> > the
> > tag and diff'ing against the import directory. It seems this would be
> > handled better (hopefully faster) by using "svn export" and bypassing
> > the "-x .svn" on diff.
> >
> > [[[
> > * contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in
> >   Export instead of checkout for final consistency check.
> > ]]]
> 
> Mark, what performance difference have you measured with this patch?

Well, none ... and entirely for lack of trying! (Hence the "hopefully"
in my original post. ;-)

To be honest, I think one would need quite a large import to (possibly)
see a significant difference in the final consistency check. And in the
grand scheme of all the other tasks performed by svn_load_dirs.pl, even
an improvement in this step would likely not cut the overall time by a
noticeable amount. The question is really a matter of how much faster is
export versus checkout, and at what tree size does this difference
become measurable? Hopefully one of the smart SVN developers could shed
more light on that.

I just saw the checkout followed by "diff -x .svn" and thought, "Boy,
that seems odd".

But there are other advantages, not the least of which is 1/2 the disk
space required for the export versus the checkout. I am working with a
1.5G vendor drop, so that is a non-trivial savings for me. Also, my
vendor drop contained some remnants of .svn directories, which I only
discovered by way of the final consistency check when diff was run w/o
"-x .svn". That was a nice bonus!

Mark

-- 
----------------------
Mark S. Reibert, Ph.D.
svn@reibert.com
----------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: [PATCH] svn_load_dirs.pl: export for final consistency check

Posted by Daniel Rall <dl...@finemaltcoding.com>.
On Aug 29, 2007, at 4:24 PM, Mark Reibert wrote:

> Hi,
>
> svn_load_dirs.pl performs a final consistency check by checking out  
> the
> tag and diff'ing against the import directory. It seems this would be
> handled better (hopefully faster) by using "svn export" and bypassing
> the "-x .svn" on diff.
>
> [[[
> * contrib/client-side/svn_load_dirs/svn_load_dirs.pl.in
>   Export instead of checkout for final consistency check.
> ]]]

Mark, what performance difference have you measured with this patch?

Thanks, Dan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org