[GitHub] sijie closed pull request #1175: Create a forked JVM for each bc test

[GitBox <gi...@apache.org>]

sijie closed pull request #1175: Create a forked JVM for each bc test
URL: https://github.com/apache/bookkeeper/pull/1175
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/tests/integration-tests-base-groovy/pom.xml b/tests/integration-tests-base-groovy/pom.xml
index 875361c43..9bf71b081 100644
--- a/tests/integration-tests-base-groovy/pom.xml
+++ b/tests/integration-tests-base-groovy/pom.xml
@@ -84,10 +84,14 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
+        <!-- DO NOT CHANGE VERSION
+             Versions newer than 2.8.1 do not respect useSystemClassLoader=false
+             https://issues.apache.org/jira/browse/SUREFIRE-1476 //-->
+        <version>2.8.1</version>
         <configuration>
-          <!-- forkCount=0 forces groovy tests to run in isolated classloaders
-               which is required if want to test BC without test deps interfering //-->
-          <forkCount>0</forkCount>
+          <argLine>-Xmx4G -Djava.net.preferIPv4Stack=true</argLine>
+          <forkCount>1</forkCount>
+          <useSystemClassLoader>false</useSystemClassLoader>
           <systemPropertyVariables>
             <!-- only takes effect in later simpleLogger versions (1.7+) //-->
             <org.slf4j.simpleLogger.logFile>System.out</org.slf4j.simpleLogger.logFile>
diff --git a/tests/integration-tests-utils/pom.xml b/tests/integration-tests-utils/pom.xml
index fb6654ab8..35fb4c821 100644
--- a/tests/integration-tests-utils/pom.xml
+++ b/tests/integration-tests-utils/pom.xml
@@ -99,11 +99,13 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-surefire-plugin</artifactId>
+        <!-- DO NOT CHANGE VERSION
+             Versions newer than 2.8.1 do not respect useSystemClassLoader=false
+             https://issues.apache.org/jira/browse/SUREFIRE-1476 //-->
+        <version>2.8.1</version>
         <configuration>
-          <!-- forkCount=0 forces tests to run in isolated classloaders
-               which is required if want to test maven classloader without
-               test deps interfering //-->
-          <forkCount>0</forkCount>
+          <forkCount>1</forkCount>
+          <useSystemClassLoader>false</useSystemClassLoader>
         </configuration>
       </plugin>
     </plugins>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services