You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by GitBox <gi...@apache.org> on 2020/07/30 18:07:13 UTC

[GitHub] [groovy] eric-milles opened a new pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

eric-milles opened a new pull request #1330:
URL: https://github.com/apache/groovy/pull/1330


    - `Thread.currentThread().getContextClassLoader()` was used starting with 46b1fface0b17cf41f9681894bcb8d78fc831258 -- commit does not state that this parentage is required for any specific reason; fallback loader (the one that loaded `ProcessingUnit`) seems like a better option for Groovy.
   
    - `StaticTypeCheckingSupport.evaluateExpression(...)` relies on loader created by this block; it does not transfer loader(s) from it's context.
   
   
   This came about for me because IDE is performing content assist asynchronously now and processing `ClosureParams`/`DelegatesTo` metadata relies on `evaluateExpression`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] asfgit closed pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1330:
URL: https://github.com/apache/groovy/pull/1330


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] blackdrag commented on pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

Posted by GitBox <gi...@apache.org>.
blackdrag commented on pull request #1330:
URL: https://github.com/apache/groovy/pull/1330#issuecomment-666576029


   @eric-milles what about first getting the context loader and check if it can load ProcessingUnit and if the ProcessingUnit loaded by that is the same as the presented ProcessingLoader class, and only fall back to ProcessingUnit.class.classLoader if that fails?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] eric-milles commented on pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

Posted by GitBox <gi...@apache.org>.
eric-milles commented on pull request #1330:
URL: https://github.com/apache/groovy/pull/1330#issuecomment-666586087


   I just went with the simplest alternative.  If there is a specific reason that the context class loader is needed, I'm interested to know why.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] blackdrag commented on pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

Posted by GitBox <gi...@apache.org>.
blackdrag commented on pull request #1330:
URL: https://github.com/apache/groovy/pull/1330#issuecomment-666613745


   @eric-milles that was just to keep backwards compatibility. It is difficult to find a reason for something somebody else wrote 15 years ago and did not create a ticket for, nor is it easy to tell if that "feature" is used by someone


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [groovy] danielsun1106 commented on pull request #1330: The fork-join pool does not provide a good ClassLoader for Groovy types

Posted by GitBox <gi...@apache.org>.
danielsun1106 commented on pull request #1330:
URL: https://github.com/apache/groovy/pull/1330#issuecomment-671001607


   Merged with some trivial tweaks for better backward compatibility. Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org