[GitHub] [arrow] nealrichardson commented on a change in pull request #8932: ARROW-10856: [R] CC and CXX environment variables passing to cmake

[GitBox <gi...@apache.org>]

nealrichardson commented on a change in pull request #8932:
URL: https://github.com/apache/arrow/pull/8932#discussion_r543737749



##########
File path: r/tools/linuxlibs.R
##########
@@ -379,40 +379,41 @@ cmake_version <- function(cmd = "cmake") {
   )
 }
 
-with_s3_support <- function(env_vars) {
+with_s3_support <- function(env_vars, cmake) {
   arrow_s3 <- toupper(Sys.getenv("ARROW_S3")) == "ON" || tolower(Sys.getenv("LIBARROW_MINIMAL")) == "false"
   if (arrow_s3) {
     # User wants S3 support. Let's make sure they're not on gcc < 4.9
     # and make sure that we have curl and openssl system libs
-    info <- system(paste(env_vars, "&& $CMAKE --system-information"), intern = TRUE)
+    info <- system(paste(env_vars, cmake, "--system-information"), intern = TRUE)

Review comment:
       `/path/to/cmake` is passed in as `CMAKE` in the env_vars, hence why cmake was invoked as `$CMAKE`. Would `paste("export", env_vars, "&& $CMAKE --system-information")` also solve this?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org