You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/07 02:58:22 UTC

[GitHub] [rocketmq] RongtongJin opened a new pull request, #4793: [ISSUE #4792] Add getControllerConfig and updateControllerConfig command for admin CLI

RongtongJin opened a new pull request, #4793:
URL: https://github.com/apache/rocketmq/pull/4793

**Make sure set the target branch to `develop`**

## What is the purpose of the change

Add getControllerConfig and updateControllerConfig command for admin CLI

## Brief changelog

Add getControllerConfig and updateControllerConfig command for admin CLI

## Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.

- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4793: [ISSUE #4792] Add getControllerConfig and updateControllerConfig command for admin CLI

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #4793:
URL: https://github.com/apache/rocketmq/pull/4793#issuecomment-1207328874

   
   [![Coverage Status](https://coveralls.io/builds/51470304/badge)](https://coveralls.io/builds/51470304)
   
   Coverage decreased (-0.05%) to 49.158% when pulling **09e328af361354c5d0258524e998f2bdcdc1852b on RongtongJin:add-command** into **034d7389ba32d4f95cff471e8aa2eb27c31202d1 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] ShannonDing merged pull request #4793: [ISSUE #4792] Add getControllerConfig and updateControllerConfig command for admin CLI

Posted by GitBox <gi...@apache.org>.

ShannonDing merged PR #4793:
URL: https://github.com/apache/rocketmq/pull/4793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4793: [ISSUE #4792] Add getControllerConfig and updateControllerConfig command for admin CLI

Posted by GitBox <gi...@apache.org>.

codecov-commenter commented on PR #4793:
URL: https://github.com/apache/rocketmq/pull/4793#issuecomment-1207326501

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4793?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4793](https://codecov.io/gh/apache/rocketmq/pull/4793?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09e328a) into [develop](https://codecov.io/gh/apache/rocketmq/commit/c506036cb6b6fa1461431d6c9dceb83ce4dfc7de?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c506036) will **decrease** coverage by `0.20%`.
   > The diff coverage is `4.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4793      +/-   ##
   =============================================
   - Coverage      45.07%   44.86%   -0.21%     
   + Complexity      7617     7594      -23     
   =============================================
     Files            976      978       +2     
     Lines          67808    67952     +144     
     Branches        8963     8982      +19     
   =============================================
   - Hits           30564    30488      -76     
   - Misses         33475    33682     +207     
   - Partials        3769     3782      +13     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4793?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `23.65% <0.00%> (-0.56%)` | :arrow_down: |
   | [...rocketmq/client/impl/factory/MQClientInstance.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9mYWN0b3J5L01RQ2xpZW50SW5zdGFuY2UuamF2YQ==) | `47.02% <ø> (-0.42%)` | :arrow_down: |
   | [...g/apache/rocketmq/common/protocol/RequestCode.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vcHJvdG9jb2wvUmVxdWVzdENvZGUuamF2YQ==) | `0.00% <ø> (ø)` | |
   | [...apache/rocketmq/tools/admin/DefaultMQAdminExt.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2FkbWluL0RlZmF1bHRNUUFkbWluRXh0LmphdmE=) | `32.16% <0.00%> (-0.58%)` | :arrow_down: |
   | [.../apache/rocketmq/tools/command/MQAdminStartup.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvTVFBZG1pblN0YXJ0dXAuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...tools/command/broker/GetBrokerEpochSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvYnJva2VyL0dldEJyb2tlckVwb2NoU3ViQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...mand/controller/GetControllerConfigSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29udHJvbGxlci9HZXRDb250cm9sbGVyQ29uZmlnU3ViQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...nd/controller/GetControllerMetaDataSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29udHJvbGxlci9HZXRDb250cm9sbGVyTWV0YURhdGFTdWJDb21tYW5kLmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...d/controller/UpdateControllerConfigSubCommand.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dG9vbHMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3Rvb2xzL2NvbW1hbmQvY29udHJvbGxlci9VcGRhdGVDb250cm9sbGVyQ29uZmlnU3ViQ29tbWFuZC5qYXZh) | `0.00% <0.00%> (ø)` | |
   | [...ntroller/processor/ControllerRequestProcessor.java](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvY29udHJvbGxlci9wcm9jZXNzb3IvQ29udHJvbGxlclJlcXVlc3RQcm9jZXNzb3IuamF2YQ==) | `26.19% <6.81%> (-20.62%)` | :arrow_down: |
   | ... and [34 more](https://codecov.io/gh/apache/rocketmq/pull/4793/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4793: [ISSUE #4792] Add getControllerConfig and updateControllerConfig command for admin CLI

Posted by GitBox <gi...@apache.org>.

coveralls commented on PR #4793:
URL: https://github.com/apache/rocketmq/pull/4793#issuecomment-1207328875

   
   [![Coverage Status](https://coveralls.io/builds/51470304/badge)](https://coveralls.io/builds/51470304)
   
   Coverage decreased (-0.05%) to 49.158% when pulling **09e328af361354c5d0258524e998f2bdcdc1852b on RongtongJin:add-command** into **034d7389ba32d4f95cff471e8aa2eb27c31202d1 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org