You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "gsartori (via GitHub)" <gi...@apache.org> on 2026/07/27 09:07:46 UTC
[PR] Groovy-Developer SKILL - Ternary operator [grails-core]
gsartori opened a new pull request, #16055:
URL: https://github.com/apache/grails-core/pull/16055
## Description
Adds guidance to the `groovy-developer` skill for formatting Groovy ternary expressions.
The new section recommends:
- Using ternary operators only for simple conditions.
- Splitting longer expressions across multiple lines.
- Aligning the `?` and `:` branches for readability.
This is a documentation-only change to the agent skill and does not affect Grails runtime behavior or public APIs. No automated tests are required.
No related issue exists; the change provides missing formatting guidance for generated Groovy code.
## Contributor Checklist
### Issue and Scope
- [x] Background is provided above because no approved issue exists.
- [x] This PR addresses the complete intended scope.
- [x] This PR contains a single, focused change.
- [x] This documentation-only change targets the appropriate patch release branch.
### Code Quality
- [x] Automated tests are not applicable because no executable code was changed.
- [ ] I have verified that all existing tests pass by running `./gradlew build --rerun-tasks`.
- [ ] I have run `./gradlew codeStyle`.
- [x] This PR does not include mass reformatting or unrelated refactoring.
- [x] Generative AI tooling, if used, was reviewed for consistency with project standards.
### Licensing and Attribution
- [x] The change is provided under the Apache License 2.0; no new source files were added.
- [x] I have the necessary rights to submit this contribution.
- [ ] If generative AI tooling was used, its use has been attributed according to ASF policy.
### Documentation
- [x] The relevant `groovy-developer` skill documentation was updated.
- [x] A “What’s New” update is not applicable because this is not a Grails feature.
- [x] Upgrade notes are not required because there are no breaking changes or user actions.
- [x] The PR description explains what changed and why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "gsartori (via GitHub)" <gi...@apache.org>.
gsartori commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5101430557
@jdaugherty I did a rebase on top of 8.0.x, not sure if that resolved the extra commits you are referring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5118428770
@gsartori Thank you! I've merged this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty merged PR #16055:
URL: https://github.com/apache/grails-core/pull/16055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5111102381
@gsartori there's something wrong with your history - it's including many more changes. Are you ok if I rebase your changes so it doesn't include the extra?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "gsartori (via GitHub)" <gi...@apache.org>.
gsartori commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5115115698
@jdaugherty yes please, I haven't spent enough time on the github forking thing and I am very bad with it, I am sorry for that, but that's it at the moment :/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5098260811
Can you please rebase this PR on top of 8.0.x so there aren't extra commits in it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "jdaugherty (via GitHub)" <gi...@apache.org>.
jdaugherty commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5118380897
@gsartori can you please confirm this looks right now? The diff shows only a single change to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Groovy-Developer SKILL - Ternary operator [grails-core]
Posted by "gsartori (via GitHub)" <gi...@apache.org>.
gsartori commented on PR #16055:
URL: https://github.com/apache/grails-core/pull/16055#issuecomment-5118412869
@jdaugherty it looks okay to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org