You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by sjcorbett <gi...@git.apache.org> on 2016/04/13 18:06:58 UTC
[GitHub] brooklyn-server pull request: Feature/runtime files directory
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/114
Feature/runtime files directory
So blueprint writers can replace
```yaml
brooklyn.config:
runtimeTemplates:
/path/to/source1: dest1
/path/to/source2: dest2
...
/path/to/sourceN: destN
```
With
```yaml
brooklyn.config:
runtimeTemplates:
/path/to: destinationDir
```
One minor difference: in the first example the two files end up in `runDir/` but in the second in `runDir/to/`. If using the latter syntax I think this would be expected.
Each file is copied in a task so there's better visibility of what is in progress at any given point.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server feature/runtime-files-directory
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit 940388f18fe6db02d508550bc88ffeddc2c94b8b
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2016-04-13T15:55:08Z
Os.isAbsolutish works for blank strings
commit 2f15e17844d9c4d1936975e8d353bfeb1cc0dca3
Author: Sam Corbett <sa...@cloudsoftcorp.com>
Date: 2016-04-13T15:44:40Z
AbstractSoftwareProcessDriver copyResources walks the filesystem
Meaning blueprints can refer to directories rather than every file
individually.
Each file is copied in a task so there's better visibility of what is in
progress at any given point.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Driver copyResources walks the files...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Driver copyResources walks the files...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-server/pull/114#issuecomment-212815426
Very useful. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Driver copyResources walks the files...
Posted by Graeme-Miller <gi...@git.apache.org>.
Github user Graeme-Miller commented on the pull request:
https://github.com/apache/brooklyn-server/pull/114#issuecomment-210039244
lgtm
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-server pull request: Driver copyResources walks the files...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/114#discussion_r60445132
--- Diff: launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java ---
@@ -384,7 +384,7 @@ public void terminate() {
if (getPersistMode() != PersistMode.DISABLED) {
try {
Stopwatch stopwatch = Stopwatch.createStarted();
- if (managementContext.getHighAvailabilityManager().getPersister() != null) {
+ if (managementContext.getHighAvailabilityManager() != null && managementContext.getHighAvailabilityManager().getPersister() != null) {
--- End diff --
Do you think we should do the same checks in `AbstractManagementContext.terminate()` in case startup failed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---