You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Richard Zang <rz...@hortonworks.com> on 2015/05/27 08:04:21 UTC
Review Request 34699: Enhanced configs: final icon is missing when
comparing two versions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34699/
-----------------------------------------------------------
Review request for Ambari and Srimanth Gunturi.
Summary (updated)
-----------------
Enhanced configs: final icon is missing when comparing two versions
Bugs: AMBARI-11411
https://issues.apache.org/jira/browse/AMBARI-11411
Repository: ambari
Description (updated)
-------
Show final icon when viewing previous version.
Show final icon when comparing.
Diffs (updated)
-----
ambari-web/app/styles/widgets.less efaf7b7
ambari-web/app/templates/common/configs/widgets/comparison/config_widget_comparison.hbs cab83c3
ambari-web/app/templates/common/configs/widgets/controls.hbs 4e634cb
ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js 970fffe
Diff: https://reviews.apache.org/r/34699/diff/
Testing (updated)
-------
Manually tested on live cluster.
Thanks,
Richard Zang
Re: Review Request 34699: Enhanced configs: final icon is missing when
comparing two versions
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34699/#review85882
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On May 29, 2015, 12:26 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34699/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 12:26 a.m.)
>
>
> Review request for Ambari and Srimanth Gunturi.
>
>
> Bugs: AMBARI-11411
> https://issues.apache.org/jira/browse/AMBARI-11411
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Show final icon when viewing previous version.
> Show final icon when comparing.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 8e6386d
> ambari-web/app/styles/widgets.less 897c6e5
> ambari-web/app/templates/common/configs/widgets/comparison/config_widget_comparison.hbs cab83c3
> ambari-web/app/templates/common/configs/widgets/controls.hbs da8e1ac
> ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js 970fffe
>
> Diff: https://reviews.apache.org/r/34699/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 34699: Enhanced configs: final icon is missing when
comparing two versions
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34699/
-----------------------------------------------------------
(Updated May 29, 2015, 12:26 a.m.)
Review request for Ambari and Srimanth Gunturi.
Changes
-------
Fix missing class name caused by undefined property.
Bugs: AMBARI-11411
https://issues.apache.org/jira/browse/AMBARI-11411
Repository: ambari
Description
-------
Show final icon when viewing previous version.
Show final icon when comparing.
Diffs (updated)
-----
ambari-web/app/controllers/main/service/info/configs.js 8e6386d
ambari-web/app/styles/widgets.less 897c6e5
ambari-web/app/templates/common/configs/widgets/comparison/config_widget_comparison.hbs cab83c3
ambari-web/app/templates/common/configs/widgets/controls.hbs da8e1ac
ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js 970fffe
Diff: https://reviews.apache.org/r/34699/diff/
Testing
-------
Manually tested on live cluster.
Thanks,
Richard Zang
Re: Review Request 34699: Enhanced configs: final icon is missing when
comparing two versions
Posted by Richard Zang <rz...@hortonworks.com>.
> On May 28, 2015, 5:54 p.m., Srimanth Gunturi wrote:
> > ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js, line 21
> > <https://reviews.apache.org/r/34699/diff/1/?file=972512#file972512line21>
> >
> > Is 'isBeingCompared' variable needed? I dont see its value being changed.
This is a static field indicating current view is a child view of comparison view
- Richard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34699/#review85580
-----------------------------------------------------------
On May 29, 2015, 12:26 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34699/
> -----------------------------------------------------------
>
> (Updated May 29, 2015, 12:26 a.m.)
>
>
> Review request for Ambari and Srimanth Gunturi.
>
>
> Bugs: AMBARI-11411
> https://issues.apache.org/jira/browse/AMBARI-11411
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Show final icon when viewing previous version.
> Show final icon when comparing.
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/info/configs.js 8e6386d
> ambari-web/app/styles/widgets.less 897c6e5
> ambari-web/app/templates/common/configs/widgets/comparison/config_widget_comparison.hbs cab83c3
> ambari-web/app/templates/common/configs/widgets/controls.hbs da8e1ac
> ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js 970fffe
>
> Diff: https://reviews.apache.org/r/34699/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>
Re: Review Request 34699: Enhanced configs: final icon is missing when
comparing two versions
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34699/#review85580
-----------------------------------------------------------
ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js
<https://reviews.apache.org/r/34699/#comment137165>
Is 'isBeingCompared' variable needed? I dont see its value being changed.
- Srimanth Gunturi
On May 27, 2015, 6:04 a.m., Richard Zang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34699/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 6:04 a.m.)
>
>
> Review request for Ambari and Srimanth Gunturi.
>
>
> Bugs: AMBARI-11411
> https://issues.apache.org/jira/browse/AMBARI-11411
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Show final icon when viewing previous version.
> Show final icon when comparing.
>
>
> Diffs
> -----
>
> ambari-web/app/styles/widgets.less efaf7b7
> ambari-web/app/templates/common/configs/widgets/comparison/config_widget_comparison.hbs cab83c3
> ambari-web/app/templates/common/configs/widgets/controls.hbs 4e634cb
> ambari-web/app/views/common/configs/widgets/comparison/config_widget_comparison_view.js 970fffe
>
> Diff: https://reviews.apache.org/r/34699/diff/
>
>
> Testing
> -------
>
> Manually tested on live cluster.
>
>
> Thanks,
>
> Richard Zang
>
>