You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/23 12:46:36 UTC
[GitHub] [airflow] TomAugspurger commented on issue #7786: Restore
DaskExecutor tests
TomAugspurger commented on issue #7786: Restore DaskExecutor tests
URL: https://github.com/apache/airflow/pull/7786#issuecomment-602568451
The test `TestDaskExecutor.test_backfill_integration` is failing because the executor hasn't been started.
```
def end(self) -> None:
if not self.client:
raise AirflowException(NOT_STARTED_MESSAGE)
if not self.futures:
> raise AirflowException(NOT_STARTED_MESSAGE)
E airflow.exceptions.AirflowException: The executor should be started first!
```
Would it be OK to start the Executor somewhere around https://github.com/apache/airflow/blob/4bde99f1323d72f6c84c1548079d5e98fc0a2a9a/tests/executors/test_dask_executor.py#L117? The other tests do this by calling `self.assert_tasks_on_executor(executor)`. I'm not sure whether or not that's appropriate in this test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services