You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/14 14:54:56 UTC

[GitHub] [arrow-datafusion] carols10cents opened a new pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

carols10cents opened a new pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834


   # Which issue does this PR close?
   
   Closes #1833.
   
    # Rationale for this change
   
   This seems wrong.
   
   # What changes are included in this PR?
   
   Deserializing `OctetLength` as `octet_length` instead of `length`.
   
   # Are there any user-facing changes?
   
   Deserializing should be correct, if `OctetLength` is used?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp merged pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
houqp merged pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp commented on pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834#issuecomment-1039897790


   Thanks @carols10cents 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] realno commented on pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
realno commented on pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834#issuecomment-1039651446


   Thanks for the fix! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] realno commented on pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
realno commented on pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834#issuecomment-1039651446


   Thanks for the fix! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp commented on pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834#issuecomment-1039897790


   Thanks @carols10cents 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834#issuecomment-1039188123


   Thank you @carols10cents 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] houqp merged pull request #1834: protobuf OctetLength should be deserialized as octet_length, not length

Posted by GitBox <gi...@apache.org>.
houqp merged pull request #1834:
URL: https://github.com/apache/arrow-datafusion/pull/1834


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org