You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2024/01/28 20:05:25 UTC
[PR] Bugfix/36843 allow skip params form if forms wo parameters is true [airflow]
jscheffl opened a new pull request, #37063:
URL: https://github.com/apache/airflow/pull/37063
After the last rework of the trigger form to prevent a XSS we did not fully test the UI when the configuration `show_trigger_form_if_no_params` is set to True.
This PR fixes the reported problem as reported in #36843 by submitting a virtual empty form.
Alongside I found that there is a key error if some required fields are not set, which still is validated. In such cases an Exception was produced earlier, now it is correctly forwarding and forcing the user to enter data into the form.
How to test (needs to be made manually :-( ):
- Run Airflow and trigger a DAG with params (e.g. example_params_ui_tutorial) and one without (e.g. example_bash_decorator) and see like before form is displayed depending on params defined on the DAG.
- Start webserver with `AIRFLOW__WEBSERVER__SHOW_TRIGGER_FORM_IF_NO_PARAMS=True` and try to start the two DAGs above with and without params. Shuod fix the bug reported.
closes: #36843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Bugfix Triggering DAG with parameters is mandatory when show_trigger_form_if_no_params is enabled [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #37063:
URL: https://github.com/apache/airflow/pull/37063
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org