You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/09/03 01:01:36 UTC
[GitHub] [lucene-solr] tflobbe opened a new pull request #1823: SOLR-14510: Remove deprecations added with BMW support
tflobbe opened a new pull request #1823:
URL: https://github.com/apache/lucene-solr/pull/1823
With BMW support, we added a new method to Text response writers to include in the response if the numFound is exact or not. This PR is to remove the previously existing and deprecated methods and makes the new method abstract to force it's implementation in subclasses. This is intended for master branch only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] cpoerschke commented on pull request #1823: SOLR-14510: Remove deprecations added with BMW support
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on pull request #1823:
URL: https://github.com/apache/lucene-solr/pull/1823#issuecomment-687200873
> Remove deprecations added with BMW support
> ... It would be useful to add this deprecation information ...
+1 to make it a clearer what is being deprecated. "BMW support" at first glance made me think of the car manufacturer but no, it's not that but "BlockMax WAND support" instead.
To the reader of the deprecation information, does it matter why the thing that is being removed was deprecated, I wonder? If not then something like _"Remove deprecated writeStartDocumentList variant in TextResponseWriter and its sub-classes."_ could work perhaps, though it's rather long, hmm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe merged pull request #1823: SOLR-14510: Remove deprecations added with BlockMax WAND support
Posted by GitBox <gi...@apache.org>.
tflobbe merged pull request #1823:
URL: https://github.com/apache/lucene-solr/pull/1823
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #1823: SOLR-14510: Remove deprecations added with BMW support
Posted by GitBox <gi...@apache.org>.
tflobbe commented on pull request #1823:
URL: https://github.com/apache/lucene-solr/pull/1823#issuecomment-689835989
Added a note to the upgrade section of the reference guide. Let me know what you think
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org