You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhishek Patil <pr...@gmail.com> on 2023/09/11 09:53:18 UTC
Review Request 74593: RANGER-4358: Keep the usersync details popup names same as the backbone js names
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74593/
-----------------------------------------------------------
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4358
https://issues.apache.org/jira/browse/RANGER-4358
Repository: ranger
Description
-------
The data field names are different in the usersync audits sync details popup in ReactJS when compared to backbone JS.
Ideally, both of them should be the same and the field names in React JS should be the same as in BackBone JS.
Diffs
-----
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx 42a886ef3
Diff: https://reviews.apache.org/r/74593/diff/1/
Testing
-------
Built Ranger admin with the changes and verified the behaviour in React UI
Thanks,
Abhishek Patil
Re: Review Request 74593: RANGER-4358: Keep the usersync details popup names same as the backbone js names
Posted by Mugdha Varadkar <mu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74593/#review225730
-----------------------------------------------------------
Ship it!
Ship It!
- Mugdha Varadkar
On Sept. 11, 2023, 11:14 a.m., Abhishek Patil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74593/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2023, 11:14 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4358
> https://issues.apache.org/jira/browse/RANGER-4358
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The data field names are different in the usersync audits sync details popup in ReactJS when compared to backbone JS.
> Ideally, both of them should be the same and the field names in React JS should be the same as in BackBone JS.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 6e5eb0d5b
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx 42a886ef3
>
>
> Diff: https://reviews.apache.org/r/74593/diff/2/
>
>
> Testing
> -------
>
> Built Ranger admin with the changes and verified the behaviour in React UI
>
>
> Thanks,
>
> Abhishek Patil
>
>
Re: Review Request 74593: RANGER-4358: Keep the usersync details popup names same as the backbone js names
Posted by Dhaval Rajpara <dh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74593/#review225731
-----------------------------------------------------------
Ship it!
Ship It!
- Dhaval Rajpara
On Sept. 11, 2023, 11:14 a.m., Abhishek Patil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74593/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2023, 11:14 a.m.)
>
>
> Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
>
>
> Bugs: RANGER-4358
> https://issues.apache.org/jira/browse/RANGER-4358
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The data field names are different in the usersync audits sync details popup in ReactJS when compared to backbone JS.
> Ideally, both of them should be the same and the field names in React JS should be the same as in BackBone JS.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 6e5eb0d5b
> security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx 42a886ef3
>
>
> Diff: https://reviews.apache.org/r/74593/diff/2/
>
>
> Testing
> -------
>
> Built Ranger admin with the changes and verified the behaviour in React UI
>
>
> Thanks,
>
> Abhishek Patil
>
>
Re: Review Request 74593: RANGER-4358: Keep the usersync details popup names same as the backbone js names
Posted by Abhishek Patil <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74593/
-----------------------------------------------------------
(Updated Sept. 11, 2023, 11:14 a.m.)
Review request for ranger, Dhaval Rajpara and Mugdha Varadkar.
Bugs: RANGER-4358
https://issues.apache.org/jira/browse/RANGER-4358
Repository: ranger
Description
-------
The data field names are different in the usersync audits sync details popup in ReactJS when compared to backbone JS.
Ideally, both of them should be the same and the field names in React JS should be the same as in BackBone JS.
Diffs (updated)
-----
security-admin/src/main/webapp/react-webapp/src/utils/XAEnums.js 6e5eb0d5b
security-admin/src/main/webapp/react-webapp/src/views/UserGroupRoleListing/SyncSourceDetails.jsx 42a886ef3
Diff: https://reviews.apache.org/r/74593/diff/2/
Changes: https://reviews.apache.org/r/74593/diff/1-2/
Testing
-------
Built Ranger admin with the changes and verified the behaviour in React UI
Thanks,
Abhishek Patil