You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/03/03 17:16:19 UTC
[GitHub] [incubator-iotdb] wshao08 opened a new pull request #879: Hot fix
for last bug when using with disable align
wshao08 opened a new pull request #879: Hot fix for last bug when using with disable align
URL: https://github.com/apache/incubator-iotdb/pull/879
This pr is a hot fix for last query.
1. Last query failed when using with disable align and align by device.
2. Added more integration tests for cases when querying last value among unseqenced files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin merged pull request #879: Hot fix for
LAST query bug when using with disable align
Posted by GitBox <gi...@apache.org>.
qiaojialin merged pull request #879: Hot fix for LAST query bug when using with disable align
URL: https://github.com/apache/incubator-iotdb/pull/879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request
#879: Hot fix for LAST query bug when using with disable align
Posted by GitBox <gi...@apache.org>.
qiaojialin commented on a change in pull request #879: Hot fix for LAST query bug when using with disable align
URL: https://github.com/apache/incubator-iotdb/pull/879#discussion_r387477553
##########
File path: server/src/main/java/org/apache/iotdb/db/qp/strategy/PhysicalGenerator.java
##########
@@ -242,7 +242,12 @@ private PhysicalPlan transformQuery(QueryOperator queryOperator)
} else {
queryPlan = new RawDataQueryPlan();
}
- if (queryOperator.isAlignByDevice()) {
+ if (queryPlan instanceof LastQueryPlan) {
+ // Last query result set will not be affected by alignment
+ queryPlan.setAlignByTime(true);
Review comment:
false?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services