You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "matthiasblaesing (via GitHub)" <gi...@apache.org> on 2025/03/12 20:17:48 UTC

[PR] JShell Integration: Improve handling of "var" support [netbeans]

matthiasblaesing opened a new pull request, #8327:
URL: https://github.com/apache/netbeans/pull/8327

   # Part 1: Lexer: Improve handling of grammars using a lexer with backtracking
   
   Entering:
   
   ```
   var x = "Test"<Enter>
   ```
   
   into a java platform shell yields exceptions. Checking the java lexer
   showed, that the java lexer at that point does backtracking and this
   indicates a problem in the lexer infrastructure.  The problem seems
   to be caused by the generic lexer infrastructure, which has special
   handling for languages embedded into other languages. In the case of
   the jshell lexer, this is java code inside the shells code. In combination
   with a backtracking lexer this seems to break lexing.
   
   # Part 2:  Improve handling of `var` Statement
   
   - parser falsely reports that var is not supported
   - parser reports missing semikolon
   
   The first condition needs to be newly caught, the second condition was
   partially caught in `SemicolonMissingRule`, but failed because there is an
   potential off-by-one issue.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JShell Integration: Improve handling of "var" support [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing closed pull request #8327: JShell Integration: Improve handling of "var" support
URL: https://github.com/apache/netbeans/pull/8327


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JShell Integration: Improve handling of "var" support [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8327:
URL: https://github.com/apache/netbeans/pull/8327#issuecomment-2887622192

   Closing - noticed regressions in freemarker plugin and need to reevaluate first.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists


Re: [PR] JShell Integration: Improve handling of "var" support [netbeans]

Posted by "matthiasblaesing (via GitHub)" <gi...@apache.org>.
matthiasblaesing commented on PR #8327:
URL: https://github.com/apache/netbeans/pull/8327#issuecomment-2803070375

   I intent to merge this early in the NB27 cycle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists