You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Simon Kitching <sk...@apache.org> on 2006/08/16 10:43:58 UTC
Re: [logging] pom for commons-logging-api and building/testing JCL
with Maven 1
Hi,
I'm a little puzzled by this.
I have recently created a completely functional pom.xml file for
logging, which is checked in in trunk.
This pom declares all dependencies as optional (except when compiling a
checked-out svn release), so I think the same file is suitable for use
as a pom for commons-logging-api.jar without modifications.
Regards,
Simon
On Fri, 2006-08-11 at 21:03 +0200, Dennis Lundberg wrote:
> Carlos Sanchez wrote:
> > If it's this one
> > http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/commons-logging-api.pom?view=markup
>
> Yes, that's the one.
>
> > I'd remove optional from both dependencies, it's not needed being
> > scope test or plugins.
>
> Done. Thanks for reviewing.
>
> > So it has no dependencies at all, isn't it?
>
> Yes, it doesn't have any dependencies.
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [logging] pom for commons-logging-api and building/testing JCLwith
Maven 1
Posted by Nicolas De Loof <ni...@capgemini.com>.
I didn't read the start of this topic, but just my 2 cents about
creating more sub-projects for implementation specifics :
You're suggesting to split the project into modules for log4j, avalon
and so on.
Using maven2 you can create those artifacts as POM (not jars) and keep
commons-logging as a main jar with optional dependencies. The specific
poms only declare commons-logging and required dependencies for a
particular use-case. You can consider such poms as "profiles" for some
typical use of the lib (but "profile" has other meaning in maven2).
I myself use this for my corporate projects : only declare a dependency
to "mycompany:webapp" and you get all required libs for a typical webapp
(typical = the way we used to build webapps, other people may consider
some of those dependencies useless)
> I think it is a good idea to keep the tiny commons-logging-api as separate
> artifact and allow people to only depend on that.
>
> For the review of the pom.xml some comments from me:
> - -consider about spitting off commons-logging-api as a separate project with its
> own pom.xml. The build logic could be so much simpler.
>
> - -what do you think about a common pom.xml for all commons?
>
> - -whenever you swith to maven2 then you should switch to the default directory
> layout
>
> - -the profile based dependency stuff is also very complicated magic. Following
> the maven2 conventions could make it a lot easier. But this might require that
> you split of the implementation (commons-logging-logj4, commons-logging-avalon,
> etc.) then you even do not need to declare the dependencies optional - I gues
> you are not looking foreward to do this (e.g. from the maintaince point of view)...
>
> Regards
> Jörg
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.3 (GNU/Linux)
> Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
>
> iD8DBQFE5OG2mPuec2Dcv/8RAow/AJ9mIdj40xd7kXwq0FSSVQ0oTnOTyQCfdmdn
> UBpuYgDNsa82Z+V3DcRnH9U=
> =V5TA
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
>
This message contains information that may be privileged or confidential and is the property of the Capgemini Group. It is intended only for the person to whom it is addressed. If you are not the intended recipient, you are not authorized to read, print, retain, copy, disseminate, distribute, or use this message or any part thereof. If you receive this message in error, please notify the sender immediately and delete all copies of this message.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [logging] pom for commons-logging-api and building/testing JCL
with Maven 1
Posted by Joerg Hohwiller <jo...@j-hohwiller.de>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi there,
Dennis Lundberg wrote:
> Hi Simon
>
> I think this is a Maven 1 vs Maven 2 issue. As long as we deploy our
> artifacts (jars) to the Maven 1 repo, which we will do until we switch
> to Maven 2 as a build system, we need to also supply Maven 1 poms for
> them. The reason I created this pom was that the deployed
> commons-logging-api.jar does not have an accompanying pom. Adding this
> pom to the repo means that other products can set up commons-logging-api
> as a dependency.
>
I think it is a good idea to keep the tiny commons-logging-api as separate
artifact and allow people to only depend on that.
For the review of the pom.xml some comments from me:
- -consider about spitting off commons-logging-api as a separate project with its
own pom.xml. The build logic could be so much simpler.
- -what do you think about a common pom.xml for all commons?
- -whenever you swith to maven2 then you should switch to the default directory
layout
- -the profile based dependency stuff is also very complicated magic. Following
the maven2 conventions could make it a lot easier. But this might require that
you split of the implementation (commons-logging-logj4, commons-logging-avalon,
etc.) then you even do not need to declare the dependencies optional - I gues
you are not looking foreward to do this (e.g. from the maintaince point of view)...
Regards
Jörg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org
iD8DBQFE5OG2mPuec2Dcv/8RAow/AJ9mIdj40xd7kXwq0FSSVQ0oTnOTyQCfdmdn
UBpuYgDNsa82Z+V3DcRnH9U=
=V5TA
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
Re: [logging] pom for commons-logging-api and building/testing JCL
with Maven 1
Posted by Dennis Lundberg <de...@apache.org>.
Hi Simon
I think this is a Maven 1 vs Maven 2 issue. As long as we deploy our
artifacts (jars) to the Maven 1 repo, which we will do until we switch
to Maven 2 as a build system, we need to also supply Maven 1 poms for
them. The reason I created this pom was that the deployed
commons-logging-api.jar does not have an accompanying pom. Adding this
pom to the repo means that other products can set up commons-logging-api
as a dependency.
--
Dennis Lundberg
Simon Kitching wrote:
> Hi,
>
> I'm a little puzzled by this.
>
> I have recently created a completely functional pom.xml file for
> logging, which is checked in in trunk.
>
> This pom declares all dependencies as optional (except when compiling a
> checked-out svn release), so I think the same file is suitable for use
> as a pom for commons-logging-api.jar without modifications.
>
> Regards,
>
> Simon
>
> On Fri, 2006-08-11 at 21:03 +0200, Dennis Lundberg wrote:
>> Carlos Sanchez wrote:
>>> If it's this one
>>> http://svn.apache.org/viewvc/jakarta/commons/proper/logging/trunk/commons-logging-api.pom?view=markup
>> Yes, that's the one.
>>
>>> I'd remove optional from both dependencies, it's not needed being
>>> scope test or plugins.
>> Done. Thanks for reviewing.
>>
>>> So it has no dependencies at all, isn't it?
>> Yes, it doesn't have any dependencies.
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org