[GitHub] [helix] manick02 commented on a change in pull request #1292: Remove closed ZKConnectionManager from connection manager pool

[GitBox <gi...@apache.org>]

manick02 commented on a change in pull request #1292:
URL: https://github.com/apache/helix/pull/1292#discussion_r473546955



##########
File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
##########
@@ -117,6 +117,7 @@ private ZkConnectionManager getOrCreateZkConnectionManager(
   private void cleanupConnectionManager(ZkConnectionManager zkConnectionManager) {
     synchronized (_connectionManagerPool) {
       zkConnectionManager.close(true);

Review comment:
       Thank you, i will understand what condition needs to be taken care before removing from the pool and come back and propose




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org