[GitHub] [flink] stevenzwu commented on a diff in pull request #19540: [FLINK-27333] Flink filesystems hadoop version upgrade to 3.3.2

[GitBox <gi...@apache.org>]

stevenzwu commented on code in PR #19540:
URL: https://github.com/apache/flink/pull/19540#discussion_r854610694


##########
flink-filesystems/flink-s3-fs-hadoop/src/main/java/org/apache/flink/fs/s3hadoop/S3FileSystemFactory.java:
##########
@@ -94,6 +94,11 @@ protected URI getInitURI(URI fsUri, org.apache.hadoop.conf.Configuration hadoopC
     @Override
     protected S3AccessHelper getS3AccessHelper(FileSystem fs) {
         final S3AFileSystem s3Afs = (S3AFileSystem) fs;
-        return new HadoopS3AccessHelper(s3Afs, s3Afs.getConf());
+        return new HadoopS3AccessHelper(
+                s3Afs,
+                s3Afs.getConf(),
+                s3Afs.createStoreContext().getInstrumentation(),

Review Comment:
   we can probably do the extraction inside the HadoopS3AccessHelper constructor without changing here and the constructor signature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org