[GitHub] [samza] james-deee commented on a diff in pull request #1628: SAMZA-2757 : Make Samza Compatible with Java 11

[GitBox <gi...@apache.org>]

james-deee commented on code in PR #1628:
URL: https://github.com/apache/samza/pull/1628#discussion_r986026649


##########
gradle.properties:
##########
@@ -16,10 +16,14 @@
 # under the License.
 group=org.apache.samza
 version=1.7.0-SNAPSHOT
+# These 2 are ones that you can override using properties, like:
+# -PscalaSuffix=2.12 -PyarnVersion=2.10.1
 scalaSuffix=2.12
+yarnVersion=2.10.1
+yarn3Version=3.3.4
 
 # after changing this value, run `$ ./gradlew wrapper` and commit the resulting changed files
-gradleVersion=5.2.1
+gradleVersion=6.9.2

Review Comment:
   No it is not strictly needed to support 11. But everything seems to build and run as expected, so that it was worth at least moving forward to be more up to date. :shrug: I'm ok reverting if needed, but things seem good here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@samza.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org