You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2022/03/08 00:09:58 UTC

Re: Review Request 73677: RANGER-3469: Off-By-One Error in XUser Syncing

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73677/#review224145
-----------------------------------------------------------




ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java
Line 1023 (original), 1024 (patched)
<https://reviews.apache.org/r/73677/#comment313076>

    I think uploadedCount should be initialized to 0 instead of -1
    Same for lines 1118 & 1204


- Sailaja Polavarapu


On Dec. 10, 2021, 4 p.m., David Mollitor wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73677/
> -----------------------------------------------------------
> 
> (Updated Dec. 10, 2021, 4 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3285: Off-By-One Error in XUser Syncing
> 
> 
> Diffs
> -----
> 
>   ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java 60445043f 
> 
> 
> Diff: https://reviews.apache.org/r/73677/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Mollitor
> 
>