You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/05/17 18:42:51 UTC

[GitHub] [superset] craig-rueda commented on a change in pull request #14652: feat: Add `make update` cmd

craig-rueda commented on a change in pull request #14652:
URL: https://github.com/apache/superset/pull/14652#discussion_r633758976



##########
File path: Makefile
##########
@@ -38,6 +38,22 @@ superset:
 	# Load some data to play with
 	superset load-examples
 
+update:

Review comment:
       Maybe name this something like `update-npm` and then only do the final step, as the `install` will bump versions in the lockfile:
   
   ```
   cd superset-frontend
   npm install
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org