[GitHub] [nifi] natural commented on issue #4125: NIFI-7153 Adds ContentLengthFilter and DoSFilter

[GitBox <gi...@apache.org>]

natural commented on issue #4125: NIFI-7153 Adds ContentLengthFilter and DoSFilter
URL: https://github.com/apache/nifi/pull/4125#issuecomment-602071371
 
 
   > Thanks for the PR @natural! In addition to @ottobackwards's comment above..., more clarification about the new feature may be helpful. A couple of comments from my review.
   > 
   > It looks like the path property allows the nifi admin to set which paths the should use the larger limits. And these limits are set per context path. Is this too broad? Should the configurable paths be more specific since there are some endpoints that expect potential large payloads? It's probably ok if not initially as I can appreciate the motivation here. The nifi admin can just ensure that the large value is enough to cover those potential larges payloads.
   > 
   > What are your thoughts on configuring the `DoSFilter` in `JettyServer` as well? My only concern would be maintainability of the codebase going forward and whether folks would know to find that configuration in the future in the `webdefault.xml`.
   
   thanks for the thoughtful feedback @mcgilman 
   
   i had the two filters in different spots because that was the first way i could get them to function properly.  based on your feedback, i've put them both in the jetty server class and removed the xml parts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services