You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/05/09 10:08:43 UTC
[GitHub] [thrift] Jimexist opened a new pull request, #2603: Improve TProtocol.java, split into interfaces, reduce Kotlin extensions
Jimexist opened a new pull request, #2603:
URL: https://github.com/apache/thrift/pull/2603
<!-- Explain the changes in the pull request below: -->
Improve TProtocol.java, split into interfaces, reduce Kotlin extensions
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [ ] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [ ] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [ ] Did you squash your changes to a single commit? (not required, but preferred)
- [ ] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [ ] If your change does not involve any code, include `[skip ci]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] ctubbsii merged pull request #2603: THRIFT-5582: Improve TProtocol.java, split into interfaces, reduce Kotlin extensions
Posted by GitBox <gi...@apache.org>.
ctubbsii merged PR #2603:
URL: https://github.com/apache/thrift/pull/2603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jimexist commented on pull request #2603: THRIFT-5582: Improve TProtocol.java, split into interfaces, reduce Kotlin extensions
Posted by GitBox <gi...@apache.org>.
Jimexist commented on PR #2603:
URL: https://github.com/apache/thrift/pull/2603#issuecomment-1121697522
> Is this ready to merge? It looks okay to me.
yes - i wanted to update java generator as well but it's too convoluted, maybe for another day.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org