You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/06 09:40:34 UTC
[GitHub] [dubbo-go] sanxun0325 opened a new pull request #1565: register not use metadata configuration.
sanxun0325 opened a new pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
1:service register not use metadata configuration.
2:metadata-type=local , metadata information will not be uploaded to the configuration center
**Which issue(s) this PR fixes**:
Fixes :https://github.com/apache/dubbo-go/issues/1544
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
Metadata is not used to configure information about the registry during registration
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744632865
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
Review comment:
还有一个问题，假如用户没设置 namespace，在 config_center_config.go 里，给这个字段设置了一个默认值 dubbo，所以 url.GetParam(constant.NamespaceKey, "") 这个代码应该永远不会返回 ""，需要改一下 namespace 在 config_center_config.go 的默认值。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r746212830
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
SetGroup(config.GetApplicationConfig().Name).
SetVersion(version).
SetProxyFactoryKey(constant.DefaultKey).
- SetMetadataType(constant.RemoteMetadataStorageType).
+ SetMetadataType(config.GetApplicationConfig().MetadataType).
Build()
exporter.ServiceConfig.Implement(exporter.metadataService)
err := exporter.ServiceConfig.Export()
- logger.Infof("The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
+ logger.Infof("[Metadata Service] The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
return err
}
- logger.Warnf("The MetadataService has been exported : %v ", exporter.ServiceConfig.GetExportedUrls())
+ logger.Warnf("[Metadata Service] The MetadataService has been exported : %v ", exporter.ServiceConfig.GetExportedUrls())
Review comment:
日志这块等之后剑辉方案出来了再fix吧，我是故意写这个空格的，为了好看
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ad5a32) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/27aaaa9faa33d0b232604d108675cd5e2beec7b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27aaaa9) will **decrease** coverage by `0.06%`.
> The diff coverage is `6.06%`.
> :exclamation: Current head 6ad5a32 differs from pull request most recent head 0b33524. Consider uploading reports for the commit 0b33524 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.77% 41.70% -0.07%
==========================================
Files 258 258
Lines 15106 15091 -15
==========================================
- Hits 6310 6294 -16
- Misses 8055 8061 +6
+ Partials 741 736 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `1.85% <0.00%> (+0.01%)` | :arrow_up: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `1.08% <0.00%> (+<0.01%)` | :arrow_up: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `1.27% <0.00%> (+<0.01%)` | :arrow_up: |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.21% <0.00%> (+0.06%)` | :arrow_up: |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.73% <100.00%> (ø)` | |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `82.69% <100.00%> (ø)` | |
| [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.17% <0.00%> (-13.19%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.95% <0.00%> (-3.81%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27aaaa9...0b33524](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zhaoyunxing92 commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744605992
##########
File path: remoting/nacos/builder.go
##########
@@ -72,7 +72,7 @@ func GetNacosConfig(url *common.URL) ([]nacosConstant.ServerConfig, nacosConstan
serverConfigs = append(serverConfigs, nacosConstant.ServerConfig{IpAddr: ip, Port: uint64(port)})
}
- timeout := url.GetParamDuration(constant.ConfigTimeoutKey, constant.DefaultRegTimeout)
+ timeout := url.GetParamDuration(constant.RegistryTimeoutKey, constant.DefaultRegTimeout)
Review comment:
这个地方修改了话需要修改`config_center_config`里面的`urlMap.Set(constant.CONFIG_TIMEOUT_KEY, c.Timeout)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-964751670
@Mulavar
https://github.com/apache/dubbo-go/pull/1565#discussion_r744632865
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r745695074
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
SetGroup(config.GetApplicationConfig().Name).
SetVersion(version).
SetProxyFactoryKey(constant.DefaultKey).
- SetMetadataType(constant.RemoteMetadataStorageType).
+ SetMetadataType(config.GetApplicationConfig().MetadataType).
Build()
exporter.ServiceConfig.Implement(exporter.metadataService)
err := exporter.ServiceConfig.Export()
- logger.Infof("The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
+ logger.Infof("[Metadata Service] The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
return err
}
- logger.Warnf("The MetadataService has been exported : %v ", exporter.ServiceConfig.GetExportedUrls())
+ logger.Warnf("[Metadata Service] The MetadataService has been exported : %v ", exporter.ServiceConfig.GetExportedUrls())
Review comment:
Please remove the useless space at the last.
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
SetGroup(config.GetApplicationConfig().Name).
SetVersion(version).
SetProxyFactoryKey(constant.DefaultKey).
- SetMetadataType(constant.RemoteMetadataStorageType).
+ SetMetadataType(config.GetApplicationConfig().MetadataType).
Build()
exporter.ServiceConfig.Implement(exporter.metadataService)
err := exporter.ServiceConfig.Export()
- logger.Infof("The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
+ logger.Infof("[Metadata Service] The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
Review comment:
Please remove the useless space at the last.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ad5a32) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/eb6010cb3b7bf3118e8ebab0f188eee26cfe59e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6010c) will **decrease** coverage by `0.10%`.
> The diff coverage is `6.06%`.
> :exclamation: Current head 6ad5a32 differs from pull request most recent head 94434b4. Consider uploading reports for the commit 94434b4 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.70% -0.11%
==========================================
Files 258 258
Lines 15117 15091 -26
==========================================
- Hits 6321 6294 -27
- Misses 8055 8061 +6
+ Partials 741 736 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `1.85% <0.00%> (+0.01%)` | :arrow_up: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `1.08% <0.00%> (+<0.01%)` | :arrow_up: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `1.27% <0.00%> (+<0.01%)` | :arrow_up: |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.21% <0.00%> (+0.06%)` | :arrow_up: |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.73% <100.00%> (ø)` | |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `82.69% <100.00%> (ø)` | |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <0.00%> (-8.11%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6010c...94434b4](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962779536
Thanks for your contribution, I'll test it locally to confirm soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (001f95c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/eb6010cb3b7bf3118e8ebab0f188eee26cfe59e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6010c) will **decrease** coverage by `0.05%`.
> The diff coverage is `49.37%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.75% -0.06%
==========================================
Files 258 258
Lines 15117 15137 +20
==========================================
Hits 6321 6321
- Misses 8055 8077 +22
+ Partials 741 739 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/router/v3router/router\_chain.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvcm91dGVyX2NoYWluLmdv) | `41.80% <0.00%> (ø)` | |
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `22.78% <0.00%> (-0.60%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <0.00%> (ø)` | |
| [metadata/service/local/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlLmdv) | `73.52% <0.00%> (-0.55%)` | :arrow_down: |
| [metadata/service/local/service\_proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlX3Byb3h5Lmdv) | `63.09% <0.00%> (-0.77%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `1.98% <0.00%> (ø)` | |
| [registry/base\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvYmFzZV9yZWdpc3RyeS5nbw==) | `1.22% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `10.81% <0.00%> (ø)` | |
| ... and [43 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6010c...001f95c](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ebc38b) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/eb6010cb3b7bf3118e8ebab0f188eee26cfe59e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6010c) will **decrease** coverage by `0.01%`.
> The diff coverage is `48.73%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.79% -0.02%
==========================================
Files 258 258
Lines 15117 15137 +20
==========================================
+ Hits 6321 6327 +6
- Misses 8055 8076 +21
+ Partials 741 734 -7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/router/v3router/router\_chain.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvcm91dGVyX2NoYWluLmdv) | `41.80% <0.00%> (ø)` | |
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `22.78% <0.00%> (-0.60%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <0.00%> (ø)` | |
| [metadata/service/local/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlLmdv) | `73.52% <0.00%> (-0.55%)` | :arrow_down: |
| [metadata/service/local/service\_proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlX3Byb3h5Lmdv) | `63.09% <0.00%> (-0.77%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `1.98% <0.00%> (ø)` | |
| [registry/base\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvYmFzZV9yZWdpc3RyeS5nbw==) | `1.22% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `10.81% <0.00%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6010c...2ebc38b](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2ebc38b) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/eb6010cb3b7bf3118e8ebab0f188eee26cfe59e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6010c) will **decrease** coverage by `0.01%`.
> The diff coverage is `48.73%`.
> :exclamation: Current head 2ebc38b differs from pull request most recent head 001f95c. Consider uploading reports for the commit 001f95c to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.79% -0.02%
==========================================
Files 258 258
Lines 15117 15137 +20
==========================================
+ Hits 6321 6327 +6
- Misses 8055 8076 +21
+ Partials 741 734 -7
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [cluster/router/v3router/router\_chain.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9yb3V0ZXIvdjNyb3V0ZXIvcm91dGVyX2NoYWluLmdv) | `41.80% <0.00%> (ø)` | |
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [config/metadata\_report\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL21ldGFkYXRhX3JlcG9ydF9jb25maWcuZ28=) | `22.78% <0.00%> (-0.60%)` | :arrow_down: |
| [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `0.00% <0.00%> (ø)` | |
| [metadata/service/local/service.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlLmdv) | `73.52% <0.00%> (-0.55%)` | :arrow_down: |
| [metadata/service/local/service\_proxy.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9sb2NhbC9zZXJ2aWNlX3Byb3h5Lmdv) | `63.09% <0.00%> (-0.77%)` | :arrow_down: |
| [protocol/dubbo/dubbo\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vZHViYm9fcHJvdG9jb2wuZ28=) | `1.98% <0.00%> (ø)` | |
| [registry/base\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvYmFzZV9yZWdpc3RyeS5nbw==) | `1.22% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `10.81% <0.00%> (ø)` | |
| ... and [38 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6010c...001f95c](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744595844
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
+ discoveryUrl.Location = url.Location
+ client, err := nacos.NewNacosClientByUrl(discoveryUrl)
if err != nil {
return nil, perrors.WithMessage(err, "create nacos namingClient failed.")
}
- descriptor := fmt.Sprintf("nacos-service-discovery[%s]", metadataReportConfig.Address)
+ descriptor := fmt.Sprintf("nacos-service-discovery[%s]", discoveryUrl.Location)
Review comment:
discoveryUrl -> discoveryURL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744115148
##########
File path: registry/etcdv3/service_discovery.go
##########
@@ -303,33 +302,28 @@ func (e *etcdV3ServiceDiscovery) DataChange(eventType remoting.Event) bool {
return true
}
-// newEtcdv3ServiceDiscovery
-func newEtcdV3ServiceDiscovery() (registry.ServiceDiscovery, error) {
+// newEtcdV3ServiceDiscovery
Review comment:
实在不想写注释，就加上 "// nolint" 好了。别整个这玩意。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
Mulavar commented on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-963045718
mark：该 pr 也修复了 #1573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744622690
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
Review comment:
要不这个常量名直接改成 NacosNamespaceID，和前者统一一下？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744596192
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
+ discoveryUrl.Location = url.Location
+ client, err := nacos.NewNacosClientByUrl(discoveryUrl)
Review comment:
NewNacosClientByUrl -> NewNacosClientByURL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744645735
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
Review comment:
这里改了服务发现使用 nacos 的 namespace 问题，但 nacos 在配置中心的问题好像还没有解决，因为配置中心创建 nacos client 是另一个入口，可以看一下 NewNacosConfigClientByUrl，这里会调用 GetNacosConfig，获取 namespace 的时候还是拿的 key 还是有问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-964751670
@Mulavar
https://github.com/apache/dubbo-go/pull/1565#discussion_r744632865
我删除了默认值，在samples 已经修改 见 https://github.com/apache/dubbo-go-samples/pull/293
nacos 默认值为DEFAULT_GROUP，zk默认值为dubbo，由对应实现自己决定。
已经按照这个逻辑改好了，ci通过了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zhaoyunxing92 merged pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 merged pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r746219512
##########
File path: metadata/service/exporter/configurable/exporter.go
##########
@@ -69,15 +69,15 @@ func (exporter *MetadataServiceExporter) Export(url *common.URL) error {
SetGroup(config.GetApplicationConfig().Name).
SetVersion(version).
SetProxyFactoryKey(constant.DefaultKey).
- SetMetadataType(constant.RemoteMetadataStorageType).
+ SetMetadataType(config.GetApplicationConfig().MetadataType).
Build()
exporter.ServiceConfig.Implement(exporter.metadataService)
err := exporter.ServiceConfig.Export()
- logger.Infof("The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
+ logger.Infof("[Metadata Service] The MetadataService exports urls : %v ", exporter.ServiceConfig.GetExportedUrls())
Review comment:
同上
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r746224209
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
+ discoveryUrl.Location = url.Location
+ client, err := nacos.NewNacosClientByUrl(discoveryUrl)
Review comment:
Fixed
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
+ discoveryUrl.Location = url.Location
+ client, err := nacos.NewNacosClientByUrl(discoveryUrl)
if err != nil {
return nil, perrors.WithMessage(err, "create nacos namingClient failed.")
}
- descriptor := fmt.Sprintf("nacos-service-discovery[%s]", metadataReportConfig.Address)
+ descriptor := fmt.Sprintf("nacos-service-discovery[%s]", discoveryUrl.Location)
Review comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ad5a32) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/27aaaa9faa33d0b232604d108675cd5e2beec7b1?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27aaaa9) will **decrease** coverage by `0.06%`.
> The diff coverage is `6.06%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.77% 41.70% -0.07%
==========================================
Files 258 258
Lines 15106 15091 -15
==========================================
- Hits 6310 6294 -16
- Misses 8055 8061 +6
+ Partials 741 736 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `1.85% <0.00%> (+0.01%)` | :arrow_up: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `1.08% <0.00%> (+<0.01%)` | :arrow_up: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `1.27% <0.00%> (+<0.01%)` | :arrow_up: |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.21% <0.00%> (+0.06%)` | :arrow_up: |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.73% <100.00%> (ø)` | |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `82.69% <100.00%> (ø)` | |
| [cluster/cluster/base/cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyL2Jhc2UvY2x1c3Rlcl9pbnZva2VyLmdv) | `24.17% <0.00%> (-13.19%)` | :arrow_down: |
| [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.95% <0.00%> (-3.81%)` | :arrow_down: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [27aaaa9...6ad5a32](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#discussion_r744622690
##########
File path: registry/nacos/service_discovery.go
##########
@@ -330,22 +328,21 @@ func (n *nacosServiceDiscovery) String() string {
}
// newNacosServiceDiscovery will create new service discovery instance
-func newNacosServiceDiscovery() (registry.ServiceDiscovery, error) {
- metadataReportConfig := config.GetMetadataReportConfg()
- url := common.NewURLWithOptions(
- common.WithParams(make(url.Values)),
- common.WithPassword(metadataReportConfig.Password),
- common.WithUsername(metadataReportConfig.Username),
- common.WithParamsValue(constant.RegistryTimeoutKey, metadataReportConfig.Timeout))
- url.Location = metadataReportConfig.Address
- client, err := nacos.NewNacosClientByUrl(url)
+func newNacosServiceDiscovery(url *common.URL) (registry.ServiceDiscovery, error) {
+ discoveryUrl := common.NewURLWithOptions(
+ common.WithParams(url.GetParams()),
+ common.WithParamsValue(constant.NacosUsername, url.Username),
+ common.WithParamsValue(constant.NacosPassword, url.Password),
+ common.WithParamsValue(constant.NacosNamespaceID, url.GetParam(constant.NamespaceKey, "")))
Review comment:
要不这个常量名直接改成 NacosNamespaceID，和前者统一一下？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ad5a32) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/eb6010cb3b7bf3118e8ebab0f188eee26cfe59e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6010c) will **decrease** coverage by `0.10%`.
> The diff coverage is `6.06%`.
> :exclamation: Current head 6ad5a32 differs from pull request most recent head 2ebc38b. Consider uploading reports for the commit 2ebc38b to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.70% -0.11%
==========================================
Files 258 258
Lines 15117 15091 -26
==========================================
- Hits 6321 6294 -27
- Misses 8055 8061 +6
+ Partials 741 736 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `1.85% <0.00%> (+0.01%)` | :arrow_up: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `1.08% <0.00%> (+<0.01%)` | :arrow_up: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `1.27% <0.00%> (+<0.01%)` | :arrow_up: |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.21% <0.00%> (+0.06%)` | :arrow_up: |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.73% <100.00%> (ø)` | |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `82.69% <100.00%> (ø)` | |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <0.00%> (-8.11%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6010c...2ebc38b](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1565: register not use metadata configuration.
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1565:
URL: https://github.com/apache/dubbo-go/pull/1565#issuecomment-962556704
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1565](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ad5a32) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/eb6010cb3b7bf3118e8ebab0f188eee26cfe59e3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb6010c) will **decrease** coverage by `0.10%`.
> The diff coverage is `6.06%`.
> :exclamation: Current head 6ad5a32 differs from pull request most recent head 8f41bd1. Consider uploading reports for the commit 8f41bd1 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1565 +/- ##
==========================================
- Coverage 41.81% 41.70% -0.11%
==========================================
Files 258 258
Lines 15117 15091 -26
==========================================
- Hits 6321 6294 -27
- Misses 8055 8061 +6
+ Partials 741 736 -5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/extension/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2V4dGVuc2lvbi9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `0.00% <0.00%> (ø)` | |
| [registry/etcdv3/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXRjZHYzL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.34% <0.00%> (+0.03%)` | :arrow_up: |
| [registry/file/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZmlsZS9zZXJ2aWNlX2Rpc2NvdmVyeS5nbw==) | `1.85% <0.00%> (+0.01%)` | :arrow_up: |
| [registry/nacos/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3Mvc2VydmljZV9kaXNjb3ZlcnkuZ28=) | `1.08% <0.00%> (+<0.01%)` | :arrow_up: |
| [...try/servicediscovery/service\_discovery\_registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZWRpc2NvdmVyeS9zZXJ2aWNlX2Rpc2NvdmVyeV9yZWdpc3RyeS5nbw==) | `1.27% <0.00%> (+<0.01%)` | :arrow_up: |
| [registry/zookeeper/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `1.21% <0.00%> (+0.06%)` | :arrow_up: |
| [metadata/service/exporter/configurable/exporter.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvc2VydmljZS9leHBvcnRlci9jb25maWd1cmFibGUvZXhwb3J0ZXIuZ28=) | `94.73% <100.00%> (ø)` | |
| [remoting/nacos/builder.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvbmFjb3MvYnVpbGRlci5nbw==) | `82.69% <100.00%> (ø)` | |
| [config/application\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2FwcGxpY2F0aW9uX2NvbmZpZy5nbw==) | `21.62% <0.00%> (-8.11%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/dubbo-go/pull/1565/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [eb6010c...8f41bd1](https://codecov.io/gh/apache/dubbo-go/pull/1565?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org