You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Yash Sharma <ya...@gmail.com> on 2014/08/24 11:53:33 UTC

Review Request 25013: DRILL-1332 : Stats Functions on top of DRILL-1331

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25013/
-----------------------------------------------------------

Review request for drill, Jinfeng Ni and Mehant Baid.


Repository: drill-git


Description
-------

Drill-1332 patch combined with DRILL-1331.
regr_sxx, regr_syy, regr_sxy
regr_avgx, regr_avgy


Diffs
-----

  exec/java-exec/src/main/codegen/config.fmpp ff6135d 
  exec/java-exec/src/main/codegen/data/RegrTypes.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/RegrTypeFunctions.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunction.java 5e57dc7 
  exec/java-exec/src/test/resources/functions/test_regression.json PRE-CREATION 
  exec/java-exec/src/test/resources/regr_input.json PRE-CREATION 

Diff: https://reviews.apache.org/r/25013/diff/


Testing
-------

$mvn test -Dtest=TestAggregateFunction#testRegr


Thanks,

Yash Sharma

Re: Review Request 25013: DRILL-1332 : Stats Regression Functions

Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25013/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 5:33 p.m.)


Review request for drill, Jinfeng Ni and Mehant Baid.


Summary (updated)
-----------------

DRILL-1332 : Stats Regression Functions 


Repository: drill-git


Description (updated)
-------

Drill-1332 
regr_sxx, regr_syy, regr_sxy


Diffs
-----

  exec/java-exec/src/main/codegen/data/RegrTypes.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/RegrTypeFunctions.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunction.java 5e57dc7 
  exec/java-exec/src/test/resources/functions/test_regression.json PRE-CREATION 

Diff: https://reviews.apache.org/r/25013/diff/


Testing
-------

$mvn test -Dtest=TestAggregateFunction#testRegr


Thanks,

Yash Sharma

Re: Review Request 25013: DRILL-1332 : Stats Functions on top of DRILL-1331

Posted by Yash Sharma <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25013/
-----------------------------------------------------------

(Updated Aug. 28, 2014, 5:29 p.m.)


Review request for drill, Jinfeng Ni and Mehant Baid.


Changes
-------

New patch on top of DRILL-1331 (With review comments)


Repository: drill-git


Description
-------

Drill-1332 patch combined with DRILL-1331.
regr_sxx, regr_syy, regr_sxy
regr_avgx, regr_avgy


Diffs (updated)
-----

  exec/java-exec/src/main/codegen/data/RegrTypes.tdd PRE-CREATION 
  exec/java-exec/src/main/codegen/templates/RegrTypeFunctions.java PRE-CREATION 
  exec/java-exec/src/test/java/org/apache/drill/exec/fn/impl/TestAggregateFunction.java 5e57dc7 
  exec/java-exec/src/test/resources/functions/test_regression.json PRE-CREATION 

Diff: https://reviews.apache.org/r/25013/diff/


Testing
-------

$mvn test -Dtest=TestAggregateFunction#testRegr


Thanks,

Yash Sharma